Re: [Qemu-devel] [PATCH v3 01/10] qapi: Add transaction support to block-dirty-bitmap operations

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On 04/22/2015 06:04 PM, John Snow wrote:
> This adds two qmp commands to transactions.
> 
> block-dirty-bitmap-add allows you to create a bitmap simultaneously
> alongside a new full backup to accomplish a clean synchronization
> point.
> 
> block-dirty-bitmap-clear allows you to reset a bitmap back to as-if
> it were new, which can also be used alongside a full backup to
> accomplish a clean synchronization point.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---

> +++ b/docs/bitmaps.md
> @@ -97,7 +97,7 @@ which is included at the end of this document.
>  }
>  ```
>  
> -## Transactions (Not yet implemented)
> +## Transactions
>  
>  * Transactional commands are forthcoming in a future version,
>    and are not yet available for use. This section serves as

You got the section heading, but missed the next paragraph.

But (as you just proved in this attempt) deleting even more stale docs
doesn't invalidate my R-b on the code :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]