From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlGDY-00066D-N8 for qemu-devel@nongnu.org; Thu, 23 Apr 2015 08:26:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlGDU-0002tU-Ig for qemu-devel@nongnu.org; Thu, 23 Apr 2015 08:26:56 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:59320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlGDU-0002tC-8X for qemu-devel@nongnu.org; Thu, 23 Apr 2015 08:26:52 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 23 Apr 2015 13:26:49 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 437B417D805A for ; Thu, 23 Apr 2015 13:27:27 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t3NCQlte8585604 for ; Thu, 23 Apr 2015 12:26:47 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t3NCQjF4001846 for ; Thu, 23 Apr 2015 06:26:47 -0600 Message-ID: <5538E504.4010901@de.ibm.com> Date: Thu, 23 Apr 2015 14:26:44 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1428569498-27393-1-git-send-email-cornelia.huck@de.ibm.com> <1428569498-27393-2-git-send-email-cornelia.huck@de.ibm.com> In-Reply-To: <1428569498-27393-2-git-send-email-cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/10] s390x/kvm: Remove message about "switch_amode" kernel parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , qemu-devel@nongnu.org Cc: jfrei@linux.vnet.ibm.com, agraf@suse.de, Thomas Huth Am 09.04.2015 um 10:51 schrieb Cornelia Huck: > From: Thomas Huth > > The "switch_amode" parameter has been removed from the Linux kernel > sources since version 3.7 - so QEMU should not advise this parameter > nowadays anymore. > > Signed-off-by: Thomas Huth > Acked-by: Cornelia Huck > Signed-off-by: Cornelia Huck > --- > kvm-all.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index dd44f8c..7c8537b 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -1542,11 +1542,6 @@ static int kvm_init(MachineState *ms) > if (ret < 0) { > fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret, > strerror(-ret)); > - > -#ifdef TARGET_S390X > - fprintf(stderr, "Please add the 'switch_amode' kernel parameter to " > - "your host kernel command line\n"); > -#endif > goto err; > } > Can you drop this patch from your upcoming pull request? See the discussion on http://marc.info/?l=kvm&m=142978728714865&w=2 We might want to change the error message instead of getting rid of it. Christian