From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1YlIz4-0006ot-5s
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 11:24:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1YlIz0-0007wT-QS
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 11:24:09 -0400
Received: from mail-wg0-f46.google.com ([74.125.82.46]:33902)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1YlIz0-0007wP-KC
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 11:24:06 -0400
Received: by wgso17 with SMTP id o17so22212636wgs.1
	for <qemu-devel@nongnu.org>; Thu, 23 Apr 2015 08:24:06 -0700 (PDT)
Message-ID: <55390DFA.70201@linaro.org>
Date: Thu, 23 Apr 2015 17:21:30 +0200
From: Eric Auger <eric.auger@linaro.org>
MIME-Version: 1.0
References: <1429801716-8027-1-git-send-email-eric.auger@linaro.org>
	<1429801716-8027-2-git-send-email-eric.auger@linaro.org>
	<55390E40.5000503@redhat.com>
In-Reply-To: <55390E40.5000503@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/2] kvm-all.c: add qemu_irq/gsi hash
 table and utility routines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, eric.auger@st.com, qemu-devel@nongnu.org, peter.maydell@linaro.org, agraf@suse.de
Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, patches@linaro.org

On 04/23/2015 05:22 PM, Paolo Bonzini wrote:
> 
> 
> On 23/04/2015 17:08, Eric Auger wrote:
>>  int kvm_irqchip_add_irqfd_notifier(KVMState *s, EventNotifier *n,
>>                                     EventNotifier *rn, int virq);
>>  int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
>> +int kvm_irqchip_add_qemuirq_irqfd_notifier(KVMState *s, EventNotifier *n,
>> +                                           EventNotifier *rn, qemu_irq irq);
>> +int kvm_irqchip_remove_qemuirq_irqfd_notifier(KVMState *s, EventNotifier *n,
>> +                                              qemu_irq irq);
> 
> 
> Perhaps rename the existing ones to
> 
> kvm_irqchip_add_irqfd_notifier_gsi
> kvm_irqchip_remove_irqfd_notifier_gsi
> 
> and change the new ones to kvm_irqchip_add_irqfd_notifier and
> kvm_irqchip_remove_irqfd_notifier?
OK thanks!

Eric
> 
> Okay with that change; include it in the vfio-platform series and I'll
> ack it.
> 
> Paolo
>