From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlIxt-0005qb-2d for qemu-devel@nongnu.org; Thu, 23 Apr 2015 11:22:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlIxp-0007RR-TO for qemu-devel@nongnu.org; Thu, 23 Apr 2015 11:22:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlIxp-0007RI-Lx for qemu-devel@nongnu.org; Thu, 23 Apr 2015 11:22:53 -0400 Message-ID: <55390E40.5000503@redhat.com> Date: Thu, 23 Apr 2015 17:22:40 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1429801716-8027-1-git-send-email-eric.auger@linaro.org> <1429801716-8027-2-git-send-email-eric.auger@linaro.org> In-Reply-To: <1429801716-8027-2-git-send-email-eric.auger@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] kvm-all.c: add qemu_irq/gsi hash table and utility routines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger , eric.auger@st.com, qemu-devel@nongnu.org, peter.maydell@linaro.org, agraf@suse.de Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org, patches@linaro.org On 23/04/2015 17:08, Eric Auger wrote: > int kvm_irqchip_add_irqfd_notifier(KVMState *s, EventNotifier *n, > EventNotifier *rn, int virq); > int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq); > +int kvm_irqchip_add_qemuirq_irqfd_notifier(KVMState *s, EventNotifier *n, > + EventNotifier *rn, qemu_irq irq); > +int kvm_irqchip_remove_qemuirq_irqfd_notifier(KVMState *s, EventNotifier *n, > + qemu_irq irq); Perhaps rename the existing ones to kvm_irqchip_add_irqfd_notifier_gsi kvm_irqchip_remove_irqfd_notifier_gsi and change the new ones to kvm_irqchip_add_irqfd_notifier and kvm_irqchip_remove_irqfd_notifier? Okay with that change; include it in the vfio-platform series and I'll ack it. Paolo