From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlJuG-0007Ek-Gf for qemu-devel@nongnu.org; Thu, 23 Apr 2015 12:23:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlJuB-00035D-DP for qemu-devel@nongnu.org; Thu, 23 Apr 2015 12:23:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlJuB-00034v-84 for qemu-devel@nongnu.org; Thu, 23 Apr 2015 12:23:11 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 90CE891582 for ; Thu, 23 Apr 2015 16:23:09 +0000 (UTC) Message-ID: <55391C6C.90906@redhat.com> Date: Thu, 23 Apr 2015 12:23:08 -0400 From: John Snow MIME-Version: 1.0 References: <1429799701-27089-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1429799701-27089-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/4] scripts: qmp-shell: add transaction support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kchamart@redhat.com, lcapitulino@redhat.com On 04/23/2015 10:34 AM, John Snow wrote: > The qmp-shell is a little rudimentary, but it can be hacked > to give us some transactional support without too much difficulty. > > (1) Prep. > (2) Add support for serializing json arrays > (3) Allow users to use 'single quotes' instead of "double quotes" > (4) Add a special transaction( ... ) syntax that lets users > build up transactional commands using the existing qmp shell > syntax to define each action. > (5) Add a verbose flag to display generated QMP commands. > > The parsing is not as robust as one would like, but this suffices > without adding a proper parser. > > Design considerations: > > (1) Try not to disrupt the existing design of the qmp-shell. The existing > API is not disturbed. > > (2) Pick a "magic token" such that it could not be confused for legitimate > QMP/JSON syntax. Parentheses are used for this purpose. > > === > v3: > === > > - Folding in hotfix from list (import ast) > > === > v2: > === > > - Squash patches 2 & 3: > - Remove wholesale replacement of single quotes, in favor of try blocks > that attempt to parse as pure JSON, then as Python. > - Factored out the value parser block to accomplish the above. > - Allow both true/True and false/False for values. > - Fix typo in patch 3 cover letter. (was patch 4.) > > John Snow (4): > scripts: qmp-shell: refactor helpers > scripts: qmp-shell: Expand support for QMP expressions > scripts: qmp-shell: add transaction subshell > scripts: qmp-shell: Add verbose flag > > scripts/qmp/qmp-shell | 126 ++++++++++++++++++++++++++++++++++++++------------ > 1 file changed, 96 insertions(+), 30 deletions(-) > NACK for now, sorry for the noise, everyone. Kashyap found a bug while testing with this. Thanks, Kashyap!