From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlL6U-0005rT-H5 for qemu-devel@nongnu.org; Thu, 23 Apr 2015 13:39:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlL6Q-00062h-9w for qemu-devel@nongnu.org; Thu, 23 Apr 2015 13:39:58 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlL6Q-00062d-4z for qemu-devel@nongnu.org; Thu, 23 Apr 2015 13:39:54 -0400 Message-ID: <55392E66.8020400@codeaurora.org> Date: Thu, 23 Apr 2015 13:39:50 -0400 From: Christopher Covington MIME-Version: 1.0 References: <5538D0C2.9080303@imgtec.com> In-Reply-To: <5538D0C2.9080303@imgtec.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] arm: semihosting: Wire up A64 HLT 0xf000 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae Cc: Christopher Covington , Liviu Ionescu , QEMU Developers , Peter Maydell Hi Leon, On 04/23/2015 07:00 AM, Leon Alrae wrote: > Hi Christopher, > > On 09/04/2015 18:57, Peter Maydell wrote: >> On 9 April 2015 at 18:23, Christopher Covington >> wrote: >>> On Fri, Mar 27, 2015 at 12:40 PM, Peter Maydell >>> wrote: >>>> You need to have the semihosting_enabled check here rather >>>> than in the do_interrupt code, because otherwise we won't >>>> behave correctly in the disabled case. >>> >>> Do you have suggestions for getting semihosting_enabled defined in >>> translate-a64.c? I'm likely doing something dumb, but while #include >>> "sysemu/sysemu.h" at first seemed like the obvious approach, and >>> appears to work for -softmmu, I'm getting errors with that when >>> building -linux-user. >> >> sysemu.h is an ugly grab-bag of things that are specific to the >> system emulator config. Semihosting is always enabled for linux-user, >> so it doesn't have an equivalent switch. >> >> Let's clean this up a bit, by creating a new include/exec/semihost.h, > > Do you happen to have this clean up available somewhere? I just want to > make sure I'm not duplicating the work as my patches will touch the same > area. I'm afraid I've not yet had a chance to clean this up, and I'm not sure when I'll be able to get to it. Chris -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project