From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D64FCC432C0 for ; Mon, 2 Dec 2019 01:27:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0EEF20881 for ; Mon, 2 Dec 2019 01:27:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nOyFpCyk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0EEF20881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibaUl-0002tF-Oe for qemu-devel@archiver.kernel.org; Sun, 01 Dec 2019 20:27:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51226) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibaTv-0002PD-1D for qemu-devel@nongnu.org; Sun, 01 Dec 2019 20:26:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibaTs-0003Us-Nu for qemu-devel@nongnu.org; Sun, 01 Dec 2019 20:26:30 -0500 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:40890) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibaTp-0003TL-Ab for qemu-devel@nongnu.org; Sun, 01 Dec 2019 20:26:26 -0500 Received: by mail-pf1-x42f.google.com with SMTP id q8so1800762pfh.7 for ; Sun, 01 Dec 2019 17:26:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DSDnJQRm8/Xsa6TMJHDHoSk7ozREp7nXxct6oFQ8fbQ=; b=nOyFpCykvN3q2nqEdPdWZF8Nyk/0MZ8BW/Mxq+DM4mWBwAzAZIQT6qkKxQzQpzlAVu BcQC6rVjYUTPenU8Y4SBDeN+T3ooOyfTpYsjrx03DJ5FGO5vxyGEOzivm9xQ5DvNRZrL BvR5ffkJtmcdLHQlMXCAbqABABpLCDhMApthoBFdLiYYw+JZRgHgDzv1A/oQMkTbtXyv aOue0lyw6Vbss+2DWkCTS9+QB1twIhNDB0QTEEFXCepi8MctUGv8C3wQAAlOh6IhF4/p 10wIvmGVodA8q4DTMzRRnI2SehwyO+qYsX3/N6Ex8VJn9+hMc/I7zAWXH4rFh0hJYVbr asMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DSDnJQRm8/Xsa6TMJHDHoSk7ozREp7nXxct6oFQ8fbQ=; b=nr9k7dLQltzD60nfgqI6a0qwRNK/2tEVStoCbpdTnjPeXvGeMDw4WkUpNRXdjvCEbJ lyRrWVd7GXLaeZE5GGp8xHlW0l6HDT/2U7HnW0t4KjpENfg1/7ATtGvyGqwzBtDtaASR aPjj8J64woy+WVGm9wbNvjZOcRVG19n+Fu2L1KCnvGv+Lfg1/7ooVj2MKyp7ntcAilHM qnJX8c8rUqm5Du45j1gYNDMzywTcwCQt2yam5HPsVuRPo5MS+82SgAuySmvLfaVcl0SU ORCY+caF1Pu6tYlgcZtqvcCxM330sXKRD6SgOUYSmrv8YfSDFCxeGWGKlMtwjsU7VwyW LINQ== X-Gm-Message-State: APjAAAUHNfcMzQoWHiidHGKP0q3zN9j9/M8bWQAwZ7E2b93buJ4GQTwB kaD6GFZ41kM7gOcD+9lp1cBKDw== X-Google-Smtp-Source: APXvYqyf5Q2bD9JMMY6votMhAvRe7R0zJH1qoUtYDq4UCKwG5vVRv6ANb4lQCLoWdYI13aeIXAoifw== X-Received: by 2002:a63:fc13:: with SMTP id j19mr28390539pgi.327.1575249982860; Sun, 01 Dec 2019 17:26:22 -0800 (PST) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id r7sm15631309pfg.34.2019.12.01.17.26.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Dec 2019 17:26:21 -0800 (PST) Subject: Re: [PATCH v1 4/5] linux-user: log page table changes under -d page To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20191128194603.24818-1-alex.bennee@linaro.org> <20191128194603.24818-5-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <55396b80-3bdb-c15b-e1be-0a4b8222ac82@linaro.org> Date: Sun, 1 Dec 2019 17:26:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191128194603.24818-5-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42f X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/28/19 7:46 PM, Alex Bennée wrote: > + if (qemu_loglevel_mask(CPU_LOG_PAGE)) { > + qemu_log_lock(); > + qemu_log("new page @ 0x"TARGET_ABI_FMT_lx" updates page map:\n", start); > + log_page_dump(); > + qemu_log_unlock(); > + } Hmm. The language used here asserts a change, when we don't actually know that for a fact. It *probably* adds a new page, but it could be overwriting an old page. Can you find a better wording here? r~