From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlQHK-0005kz-Rp for qemu-devel@nongnu.org; Thu, 23 Apr 2015 19:11:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlQHG-0000HP-Qc for qemu-devel@nongnu.org; Thu, 23 Apr 2015 19:11:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlQHG-0000HF-IL for qemu-devel@nongnu.org; Thu, 23 Apr 2015 19:11:26 -0400 Message-ID: <55397C18.7080000@redhat.com> Date: Thu, 23 Apr 2015 17:11:20 -0600 From: Eric Blake MIME-Version: 1.0 References: <1429829878-26862-1-git-send-email-minyard@acm.org> In-Reply-To: <1429829878-26862-1-git-send-email-minyard@acm.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6nOuvmSxFFT1lJc4kstuDPSkqAETeWiKb" Subject: Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6nOuvmSxFFT1lJc4kstuDPSkqAETeWiKb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/23/2015 04:57 PM, minyard@acm.org wrote: > The major changes from last time are: That says this series should probably be named v2 (git format-patch/send-email -v2) or later, as part of the subject line. If the previous version is more than a couple weeks ago, it's also nice (but not required) to provide a URL to the archives of the previous discussion. >=20 > * Don't use callbacks for adding firmware tables, provide binary > blobs instead. >=20 > * Add the SSDT as a separate table. >=20 > * Modify the BIOS tests to test for the IPMI tables. >=20 Also, you might want to use git format-patch --cover-letter, which helps form a 00/17 letter with a diffstat pre-filled; the diffstat gives reviewers a quick glance at what files are touched, and how many lines of code are being impacted, which makes it easier to decide when to schedule a review for the series. More patch submission hints at: http://wiki.qemu.org/Contribute/SubmitAPa= tch --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6nOuvmSxFFT1lJc4kstuDPSkqAETeWiKb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVOXwYAAoJEKeha0olJ0NqarsIAJkyFNEJymkjWIOtVHtAxgSR pQXNda24Q5FzbOijd9IdvisedHMwfF/AQiNK7HkTigbx8iPRUGFAGSz2JyWQgymh 3Y4RTGB5kStC89eR0St0o7Gi+b0lepHaqqrwrIJD/nSAmgaxGdG9iYAyJaBgLcL2 4y6hJP+7siYhYN3sivt3vqfHPVMPTCtm4kPiWhwacHNH2dGP8VBIVzESAqp9VDgJ laDm7Une5n7aGMomlOMN0TVOgmAsscqq6s0mmtLQ+eWN2JtQfeUTVfi7K9VC2WpE mYW7BKy7Uts1xpV/BUTnBcbvVWSXgFLQ461fU4733CjwJQ+zjPC3DxnyRvOb/Cw= =ejyw -----END PGP SIGNATURE----- --6nOuvmSxFFT1lJc4kstuDPSkqAETeWiKb--