From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Auger <eric.auger@linaro.org>,
eric.auger@st.com, qemu-devel@nongnu.org,
alex.williamson@redhat.com, peter.maydell@linaro.org,
agraf@suse.de
Cc: kvmarm@lists.cs.columbia.edu, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback
Date: Fri, 24 Apr 2015 11:29:25 +0200 [thread overview]
Message-ID: <553A0CF5.9030304@redhat.com> (raw)
In-Reply-To: <553A0A4D.905@linaro.org>
On 24/04/2015 11:18, Eric Auger wrote:
>>> >> I implemented this alternative but my concern is the check method is
>>> >> called before the qemu_irq setting. So on this callback I cannot
>>> >> retrieve the qemu_irq VFIOINTp struct container object needed to setup
>>> >> irqfd hence does not work for me.
>> >
>> > Isn't the qemu_irq passed as the third argument to the callback? I
>> > thought this solution was fine because you weren't passing the "int n"
>> > from sysbus_connect_irq to your notifier.
> Yes it is. But I need to access the EventNotifiers for trigger &
> resample which were initialized before for eventfd trigger and stored in
> the container object. Will study if I can restructure the code ...
What did the notifier code look like with your patch?
Paolo
next prev parent reply other threads:[~2015-04-24 9:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 8:49 [Qemu-devel] [PATCH 0/2] irq: add get_gsi callback Eric Auger
2015-04-23 8:49 ` [Qemu-devel] [PATCH 1/2] " Eric Auger
2015-04-23 8:49 ` [Qemu-devel] [PATCH 2/2] intc: arm_gic_kvm: set the " Eric Auger
2015-04-23 9:30 ` [Qemu-devel] [PATCH 0/2] irq: add " Paolo Bonzini
2015-04-23 9:40 ` Eric Auger
2015-04-23 9:58 ` Paolo Bonzini
2015-04-23 11:25 ` Eric Auger
2015-04-24 9:01 ` Eric Auger
2015-04-24 9:11 ` Paolo Bonzini
2015-04-24 9:18 ` Eric Auger
2015-04-24 9:29 ` Paolo Bonzini [this message]
2015-04-24 9:48 ` Eric Auger
2015-04-24 10:02 ` Paolo Bonzini
2015-04-24 11:59 ` Eric Auger
2015-04-24 12:04 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553A0CF5.9030304@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=eric.auger@linaro.org \
--cc=eric.auger@st.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).