From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, afaerber@suse.de, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 5/5] tests: virtio-scsi: Add test for unaligned WRITE SAME
Date: Fri, 24 Apr 2015 13:07:42 +0200 [thread overview]
Message-ID: <553A23FE.1020603@redhat.com> (raw)
In-Reply-To: <1429872804-27321-6-git-send-email-famz@redhat.com>
On 24/04/2015 12:53, Fam Zheng wrote:
> + const uint8_t write_same_cdb[] = { 0x41, 0x00, 0x00, 0x00,
> + 0x00, 0x01, 0x02 };
The array size should be CDB_SIZE and there's 3 missing bytes in the
10-byte WRITE SAME CDB.
byte 0: WRITE SAME opcode
byte 1: all zeros, ok
byte 2...5: LBA = 1, ok
byte 6: GROUP NUMBER = 2?
Did you mean 0x00, 0x00, 0x02, 0x00?
It probably works because scsi-disk ignores bytes 6 and 9, and bytes 7-8
are some nonzero value from the stack, but it would break when changing
the array size to CDB_SIZE.
Otherwise looks good.
Thanks for writing the tests!
Paolo
next prev parent reply other threads:[~2015-04-24 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 10:53 [Qemu-devel] [PATCH 0/5] virtio-test: Test case update Fam Zheng
2015-04-24 10:53 ` [Qemu-devel] [PATCH 1/5] tests: Link libqos virtio object to virtio-scsi-test Fam Zheng
2015-04-24 10:53 ` [Qemu-devel] [PATCH 2/5] libqos: Allow calling guest_free on NULL pointer Fam Zheng
2015-04-24 10:53 ` [Qemu-devel] [PATCH 3/5] libqos: Complete virtio device ID definition list Fam Zheng
2015-04-24 10:53 ` [Qemu-devel] [PATCH 4/5] tests: virtio-scsi: Move start/stop to individual test functions Fam Zheng
2015-04-24 10:53 ` [Qemu-devel] [PATCH 5/5] tests: virtio-scsi: Add test for unaligned WRITE SAME Fam Zheng
2015-04-24 11:07 ` Paolo Bonzini [this message]
2015-04-24 11:23 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553A23FE.1020603@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).