From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YldKE-0005cl-Mt for qemu-devel@nongnu.org; Fri, 24 Apr 2015 09:07:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YldK9-0004qf-Ae for qemu-devel@nongnu.org; Fri, 24 Apr 2015 09:07:22 -0400 Received: from mail-ie0-x232.google.com ([2607:f8b0:4001:c03::232]:35372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YldK9-0004qa-6o for qemu-devel@nongnu.org; Fri, 24 Apr 2015 09:07:17 -0400 Received: by iejt8 with SMTP id t8so82898584iej.2 for ; Fri, 24 Apr 2015 06:07:16 -0700 (PDT) Sender: Corey Minyard Message-ID: <553A4002.7010009@acm.org> Date: Fri, 24 Apr 2015 08:07:14 -0500 From: Corey Minyard MIME-Version: 1.0 References: <1429829878-26862-1-git-send-email-minyard@acm.org> <553A0F0E.7030302@redhat.com> In-Reply-To: <553A0F0E.7030302@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu Reply-To: minyard@acm.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, "Michael S. Tsirkin" On 04/24/2015 04:38 AM, Paolo Bonzini wrote: > > On 24/04/2015 00:57, minyard@acm.org wrote: >> The major changes from last time are: >> >> * Don't use callbacks for adding firmware tables, provide binary >> blobs instead. >> >> * Add the SSDT as a separate table. >> >> * Modify the BIOS tests to test for the IPMI tables. > I disagree with both of the first two changes, but thanks for doing them > nevertheless. Michael, is this okay with you now? To me it was not a big deal either way. The change made the code a bit more consistent with what was already there, and having the SSDT as a separate table made the testing a lot easier, as Michael said it would. -corey