From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ylftd-0001CG-H2 for qemu-devel@nongnu.org; Fri, 24 Apr 2015 11:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ylfta-00017N-63 for qemu-devel@nongnu.org; Fri, 24 Apr 2015 11:52:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlftZ-000179-Uy for qemu-devel@nongnu.org; Fri, 24 Apr 2015 11:52:02 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3OFq1qe024265 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 24 Apr 2015 11:52:01 -0400 Message-ID: <553A66A0.9020608@redhat.com> Date: Fri, 24 Apr 2015 11:52:00 -0400 From: John Snow MIME-Version: 1.0 References: <1429864368-15249-1-git-send-email-kchamart@redhat.com> In-Reply-To: <1429864368-15249-1-git-send-email-kchamart@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, lcapitulino@redhat.com On 04/24/2015 04:32 AM, Kashyap Chamarthy wrote: > Although the canonical source of reference for QMP commands is > qapi-schema.json, for consistency's sake, update qmp-commands.hx to > state the list of supported transactionable operations, namely: > > drive-backup > blockdev-backup > blockdev-snapshot-internal-sync > abort These: > block-dirty-bitmap-add > block-dirty-bitmap-clear > Aren't merged yet, so it might be a little confusing. We could tack this=20 on to the end of the transaction series if you'd like, and hopefully=20 that all goes in at once before 2.4. > NB: The 'block-dirty-bitmap-add' and 'block-dirty-bitmap-clear' command= s > will be available once the in-review "transactionless incremental > backup" patch series[1] is merged upstream. > > [1] http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02161.ht= ml > > Signed-off-by: Kashyap Chamarthy > Reviewed-by: Eric Blake > --- > From v1 -> v2: > > - Update the "NB" part of the commit message by removing the duplica= te > command entry and add the missing one ('block-dirty-bitmap-clear') > - Fix grammer per Eric Blake's review: s/refer/refer to the > --- > qmp-commands.hx | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 3a42ad0bffeb23778f877410f6e2038943da46c0..b7fe31ca37afe0f4ae8f4b6= f7be5d379b361b1b8 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -1200,11 +1200,14 @@ SQMP > transaction > ----------- > > -Atomically operate on one or more block devices. The only supported o= perations > -for now are drive-backup, internal and external snapshotting. A list = of > -dictionaries is accepted, that contains the actions to be performed. > -If there is any failure performing any of the operations, all operatio= ns > -for the group are abandoned. > +Atomically operate on one or more block devices. Operations that are > +currently supported: drive-backup, blockdev-backup, > +blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, > +block-dirty-bitmap-add, block-dirty-bitmap-clear (refer to the > +qemu/qapi-schema.json file for minimum required QEMU versions for thes= e > +operations). A list of dictionaries is accepted, that contains the > +actions to be performed. If there is any failure performing any of th= e > +operations, all operations for the group are abandoned. > > For external snapshots, the dictionary contains the device, the file = to use for > the new snapshot, and the format. The default format, if not specifi= ed, is > --=20 =97js