From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlgM2-0005pA-G9 for qemu-devel@nongnu.org; Fri, 24 Apr 2015 12:21:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlgLy-0005wE-6I for qemu-devel@nongnu.org; Fri, 24 Apr 2015 12:21:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlgLx-0005w3-Vk for qemu-devel@nongnu.org; Fri, 24 Apr 2015 12:21:22 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3OGLLYm015508 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 24 Apr 2015 12:21:21 -0400 Message-ID: <553A6D80.2020004@redhat.com> Date: Fri, 24 Apr 2015 12:21:20 -0400 From: John Snow MIME-Version: 1.0 References: <1429864368-15249-1-git-send-email-kchamart@redhat.com> <553A66A0.9020608@redhat.com> <20150424162039.GA25722@tesla.redhat.com> In-Reply-To: <20150424162039.GA25722@tesla.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy Cc: kwolf@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On 04/24/2015 12:20 PM, Kashyap Chamarthy wrote: > On Fri, Apr 24, 2015 at 11:52:00AM -0400, John Snow wrote: >> >> On 04/24/2015 04:32 AM, Kashyap Chamarthy wrote: > > [. . .] > >> These: >> >>> block-dirty-bitmap-add >>> block-dirty-bitmap-clear >>> >> >> Aren't merged yet, so it might be a little confusing. > > Yeah, I expected someone to call that out, that's the reason I added the > NB at the end of the commit message which explicitly states that these > will be usable once your series (linked below) is merged, hoping that'd > clarify. > >> We could tack this on to the end of the transaction series if you'd >> like, and hopefully that all goes in at once before 2.4. > > That works too. > > If it's preferable, I can respin this to remove the mention of above two > commands and resubmit a v3. > I will defer to Eric Blake, who already gave you an R-B :)