[Qemu-devel] [PATCH v2 0/5] virtio-test: Test case update

[Qemu-devel] [PATCH v2 0/5] virtio-test: Test case update

[Fam Zheng]

v2: Fix CDB for WRITE SAME. [Paolo]

Thanks to Marc Marí's work on libqos virtio support, it's now very easy to add
a test case to drive a virtio-scsi device.

The added test covers the recent fix for unaligned zero write in block layer,
we exercise it here with scsi-disk WRITE SAME.


Fam Zheng (5):
  tests: Link libqos virtio object to virtio-scsi-test
  libqos: Allow calling guest_free on NULL pointer
  libqos: Complete virtio device ID definition list
  tests: virtio-scsi: Move start/stop to individual test functions
  tests: virtio-scsi: Add test for unaligned WRITE SAME

 tests/Makefile           |   2 +-
 tests/libqos/malloc.c    |   3 +
 tests/libqos/virtio.h    |  10 ++-
 tests/virtio-scsi-test.c | 201 +++++++++++++++++++++++++++++++++++++++++++++--
 4 files changed, 207 insertions(+), 9 deletions(-)

-- 
1.9.3

[Qemu-devel] [PATCH v2 1/5] tests: Link libqos virtio object to virtio-scsi-test

[Fam Zheng]

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/Makefile b/tests/Makefile
index 55aa745..b6c0f18 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -343,7 +343,7 @@ tests/virtio-balloon-test$(EXESUF): tests/virtio-balloon-test.o
 tests/virtio-blk-test$(EXESUF): tests/virtio-blk-test.o $(libqos-virtio-obj-y)
 tests/virtio-net-test$(EXESUF): tests/virtio-net-test.o $(libqos-pc-obj-y)
 tests/virtio-rng-test$(EXESUF): tests/virtio-rng-test.o $(libqos-pc-obj-y)
-tests/virtio-scsi-test$(EXESUF): tests/virtio-scsi-test.o
+tests/virtio-scsi-test$(EXESUF): tests/virtio-scsi-test.o $(libqos-virtio-obj-y)
 tests/virtio-9p-test$(EXESUF): tests/virtio-9p-test.o
 tests/virtio-serial-test$(EXESUF): tests/virtio-serial-test.o
 tests/virtio-console-test$(EXESUF): tests/virtio-console-test.o
-- 
1.9.3

Re: [Qemu-devel] [PATCH v2 1/5] tests: Link libqos virtio object to virtio-scsi-test

[John Snow]

On 04/24/2015 07:35 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   tests/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 55aa745..b6c0f18 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -343,7 +343,7 @@ tests/virtio-balloon-test$(EXESUF): tests/virtio-balloon-test.o
>   tests/virtio-blk-test$(EXESUF): tests/virtio-blk-test.o $(libqos-virtio-obj-y)
>   tests/virtio-net-test$(EXESUF): tests/virtio-net-test.o $(libqos-pc-obj-y)
>   tests/virtio-rng-test$(EXESUF): tests/virtio-rng-test.o $(libqos-pc-obj-y)
> -tests/virtio-scsi-test$(EXESUF): tests/virtio-scsi-test.o
> +tests/virtio-scsi-test$(EXESUF): tests/virtio-scsi-test.o $(libqos-virtio-obj-y)
>   tests/virtio-9p-test$(EXESUF): tests/virtio-9p-test.o
>   tests/virtio-serial-test$(EXESUF): tests/virtio-serial-test.o
>   tests/virtio-console-test$(EXESUF): tests/virtio-console-test.o
>

Reviewed-by: John Snow <jsnow@redhat.com>

[Qemu-devel] [PATCH v2 2/5] libqos: Allow calling guest_free on NULL pointer

[Fam Zheng]

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/libqos/malloc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/libqos/malloc.c b/tests/libqos/malloc.c
index 67f3190..c15be89 100644
--- a/tests/libqos/malloc.c
+++ b/tests/libqos/malloc.c
@@ -283,6 +283,9 @@ uint64_t guest_alloc(QGuestAllocator *allocator, size_t size)
 
 void guest_free(QGuestAllocator *allocator, uint64_t addr)
 {
+    if (!addr) {
+        return;
+    }
     mlist_free(allocator, addr);
     if (allocator->opts & ALLOC_PARANOID) {
         mlist_check(allocator);
-- 
1.9.3

Re: [Qemu-devel] [PATCH v2 2/5] libqos: Allow calling guest_free on NULL pointer

[John Snow]

On 04/24/2015 07:35 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   tests/libqos/malloc.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/libqos/malloc.c b/tests/libqos/malloc.c
> index 67f3190..c15be89 100644
> --- a/tests/libqos/malloc.c
> +++ b/tests/libqos/malloc.c
> @@ -283,6 +283,9 @@ uint64_t guest_alloc(QGuestAllocator *allocator, size_t size)
>
>   void guest_free(QGuestAllocator *allocator, uint64_t addr)
>   {
> +    if (!addr) {
> +        return;
> +    }
>       mlist_free(allocator, addr);
>       if (allocator->opts & ALLOC_PARANOID) {
>           mlist_check(allocator);
>

Reviewed-by: John Snow <jsnow@redhat.com>

[Qemu-devel] [PATCH v2 3/5] libqos: Complete virtio device ID definition list

[Fam Zheng]

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/libqos/virtio.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/libqos/virtio.h b/tests/libqos/virtio.h
index 2449fee..0101278 100644
--- a/tests/libqos/virtio.h
+++ b/tests/libqos/virtio.h
@@ -19,8 +19,14 @@
 #define QVIRTIO_DRIVER          0x2
 #define QVIRTIO_DRIVER_OK       0x4
 
-#define QVIRTIO_NET_DEVICE_ID   0x1
-#define QVIRTIO_BLK_DEVICE_ID   0x2
+#define QVIRTIO_NET_DEVICE_ID       0x1
+#define QVIRTIO_BLK_DEVICE_ID       0x2
+#define QVIRTIO_CONSOLE_DEVICE_ID   0x3
+#define QVIRTIO_RNG_DEVICE_ID       0x4
+#define QVIRTIO_BALLOON_DEVICE_ID   0x5
+#define QVIRTIO_RPMSG_DEVICE_ID     0x7
+#define QVIRTIO_SCSI_DEVICE_ID      0x8
+#define QVIRTIO_9P_DEVICE_ID        0x9
 
 #define QVIRTIO_F_NOTIFY_ON_EMPTY       0x01000000
 #define QVIRTIO_F_ANY_LAYOUT            0x08000000
-- 
1.9.3

[Qemu-devel] [PATCH v2 4/5] tests: virtio-scsi: Move start/stop to individual test functions

[Fam Zheng]

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/virtio-scsi-test.c | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c
index 989f825..ba119c1 100644
--- a/tests/virtio-scsi-test.c
+++ b/tests/virtio-scsi-test.c
@@ -12,15 +12,36 @@
 #include "libqtest.h"
 #include "qemu/osdep.h"
 
+static void qvirtio_scsi_start(const char *extra_opts)
+{
+    char *cmdline;
+
+    cmdline = g_strdup_printf(
+                "-drive id=drv0,if=none,file=/dev/null,format=raw "
+                "-device virtio-scsi-pci,id=vs0 "
+                "-device scsi-hd,bus=vs0.0,drive=drv0 %s",
+                extra_opts ? : "");
+    qtest_start(cmdline);
+    g_free(cmdline);
+}
+
+static void qvirtio_scsi_stop(void)
+{
+    qtest_end();
+}
+
 /* Tests only initialization so far. TODO: Replace with functional tests */
 static void pci_nop(void)
 {
+    qvirtio_scsi_start(NULL);
+    qvirtio_scsi_stop();
 }
 
 static void hotplug(void)
 {
     QDict *response;
 
+    qvirtio_scsi_start("-drive id=drv1,if=none,file=/dev/null,format=raw");
     response = qmp("{\"execute\": \"device_add\","
                    " \"arguments\": {"
                    "   \"driver\": \"scsi-hd\","
@@ -42,6 +63,7 @@ static void hotplug(void)
     g_assert(qdict_haskey(response, "event"));
     g_assert(!strcmp(qdict_get_str(response, "event"), "DEVICE_DELETED"));
     QDECREF(response);
+    qvirtio_scsi_stop();
 }
 
 int main(int argc, char **argv)
@@ -52,13 +74,7 @@ int main(int argc, char **argv)
     qtest_add_func("/virtio/scsi/pci/nop", pci_nop);
     qtest_add_func("/virtio/scsi/pci/hotplug", hotplug);
 
-    qtest_start("-drive id=drv0,if=none,file=/dev/null,format=raw "
-                "-drive id=drv1,if=none,file=/dev/null,format=raw "
-                "-device virtio-scsi-pci,id=vscsi0 "
-                "-device scsi-hd,bus=vscsi0.0,drive=drv0");
     ret = g_test_run();
 
-    qtest_end();
-
     return ret;
 }
-- 
1.9.3

[Qemu-devel] [PATCH v2 5/5] tests: virtio-scsi: Add test for unaligned WRITE SAME

[Fam Zheng]

This is an exercise for virtio-scsi tests using the libqos virtio
library. A few common routines are added to facilitate future extensions
of the test set.

The added test case is a regression test for the bug in d7f4b1999e.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/virtio-scsi-test.c | 173 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 173 insertions(+)

diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c
index ba119c1..91fdfef 100644
--- a/tests/virtio-scsi-test.c
+++ b/tests/virtio-scsi-test.c
@@ -2,6 +2,7 @@
  * QTest testcase for VirtIO SCSI
  *
  * Copyright (c) 2014 SUSE LINUX Products GmbH
+ * Copyright (c) 2015 Red Hat Inc.
  *
  * This work is licensed under the terms of the GNU GPL, version 2 or later.
  * See the COPYING file in the top-level directory.
@@ -11,6 +12,46 @@
 #include <string.h>
 #include "libqtest.h"
 #include "qemu/osdep.h"
+#include <stdio.h>
+#include "libqos/virtio.h"
+#include "libqos/virtio-pci.h"
+#include "libqos/pci-pc.h"
+#include "libqos/malloc.h"
+#include "libqos/malloc-pc.h"
+#include "libqos/malloc-generic.h"
+
+#define PCI_SLOT                0x02
+#define PCI_FN                  0x00
+#define QVIRTIO_SCSI_TIMEOUT_US (1 * 1000 * 1000)
+#define CDB_SIZE 32
+
+#define MAX_NUM_QUEUES 64
+
+typedef struct {
+    QVirtioDevice *dev;
+    QGuestAllocator *alloc;
+    QPCIBus *bus;
+    int num_queues;
+    QVirtQueue *vq[MAX_NUM_QUEUES + 2];
+} QVirtIOSCSI;
+
+typedef struct {
+    uint8_t lun[8];
+    int64_t tag;
+    uint8_t task_attr;
+    uint8_t prio;
+    uint8_t crn;
+    uint8_t cdb[CDB_SIZE];
+} QEMU_PACKED QVirtIOSCSICmdReq;
+
+typedef struct {
+    uint32_t sense_len;
+    uint32_t resid;
+    uint16_t status_qualifier;
+    uint8_t status;
+    uint8_t response;
+    uint8_t sense[96];
+} QEMU_PACKED QVirtIOSCSICmdResp;
 
 static void qvirtio_scsi_start(const char *extra_opts)
 {
@@ -30,6 +71,116 @@ static void qvirtio_scsi_stop(void)
     qtest_end();
 }
 
+static QVirtIOSCSI *qvirtio_scsi_pci_init(int slot)
+{
+    QVirtIOSCSI *vs;
+    QVirtioPCIDevice *dev;
+    uint64_t addr;
+    int i;
+
+    vs = g_new0(QVirtIOSCSI, 1);
+    vs->alloc = pc_alloc_init();
+    vs->bus = qpci_init_pc();
+
+    dev = qvirtio_pci_device_find(vs->bus, QVIRTIO_SCSI_DEVICE_ID);
+    vs->dev = (QVirtioDevice *)dev;
+    g_assert(dev != NULL);
+    g_assert_cmphex(vs->dev->device_type, ==, QVIRTIO_SCSI_DEVICE_ID);
+
+    qvirtio_pci_device_enable(dev);
+    qvirtio_reset(&qvirtio_pci, vs->dev);
+    qvirtio_set_acknowledge(&qvirtio_pci, vs->dev);
+    qvirtio_set_driver(&qvirtio_pci, vs->dev);
+
+
+    addr = (uint64_t)dev->addr + QVIRTIO_PCI_DEVICE_SPECIFIC_NO_MSIX;
+    vs->num_queues = qvirtio_config_readl(&qvirtio_pci, vs->dev, addr);
+
+    g_assert_cmpint(vs->num_queues, <, MAX_NUM_QUEUES);
+
+    for (i = 0; i < vs->num_queues + 2; i++) {
+        vs->vq[i] = qvirtqueue_setup(&qvirtio_pci, vs->dev, vs->alloc, i);
+    }
+
+    return vs;
+}
+
+static void qvirtio_scsi_pci_free(QVirtIOSCSI *vs)
+{
+    int i;
+
+    for (i = 0; i < vs->num_queues + 2; i++) {
+        guest_free(vs->alloc, vs->vq[i]->desc);
+    }
+    pc_alloc_uninit(vs->alloc);
+    qvirtio_pci_device_disable(container_of(vs->dev, QVirtioPCIDevice, vdev));
+    g_free(vs->dev);
+    qpci_free_pc(vs->bus);
+}
+
+static uint64_t qvirtio_scsi_alloc(QVirtIOSCSI *vs, size_t alloc_size,
+                                   const void *data)
+{
+    uint64_t addr;
+
+    addr = guest_alloc(vs->alloc, alloc_size);
+    if (data) {
+        memwrite(addr, data, alloc_size);
+    }
+
+    return addr;
+}
+
+static uint8_t virtio_scsi_do_command(QVirtIOSCSI *vs, const uint8_t *cdb,
+                                      const uint8_t *data_in,
+                                      size_t data_in_len,
+                                      uint8_t *data_out, size_t data_out_len)
+{
+    QVirtQueue *vq;
+    QVirtIOSCSICmdReq req = { { 0 } };
+    QVirtIOSCSICmdResp resp = { .response = 0xff, .status = 0xff };
+    uint64_t req_addr, resp_addr, data_in_addr = 0, data_out_addr = 0;
+    uint8_t response;
+    uint32_t free_head;
+
+    vq = vs->vq[2];
+
+    req.lun[0] = 1; /* Select LUN */
+    req.lun[1] = 1; /* Select target 1 */
+    memcpy(req.cdb, cdb, CDB_SIZE);
+
+    /* XXX: Fix endian if any multi-byte field in req/resp is used */
+
+    /* Add request header */
+    req_addr = qvirtio_scsi_alloc(vs, sizeof(req), &req);
+    free_head = qvirtqueue_add(vq, req_addr, sizeof(req), false, true);
+
+    if (data_out_len) {
+        data_out_addr = qvirtio_scsi_alloc(vs, data_out_len, data_out);
+        qvirtqueue_add(vq, data_out_addr, data_out_len, false, true);
+    }
+
+    /* Add response header */
+    resp_addr = qvirtio_scsi_alloc(vs, sizeof(resp), &resp);
+    qvirtqueue_add(vq, resp_addr, sizeof(resp), true, !!data_in_len);
+
+    if (data_in_len) {
+        data_in_addr = qvirtio_scsi_alloc(vs, data_in_len, data_in);
+        qvirtqueue_add(vq, data_in_addr, data_in_len, true, false);
+    }
+
+    qvirtqueue_kick(&qvirtio_pci, vs->dev, vq, free_head);
+    qvirtio_wait_queue_isr(&qvirtio_pci, vs->dev, vq, QVIRTIO_SCSI_TIMEOUT_US);
+
+    response = readb(resp_addr + offsetof(QVirtIOSCSICmdResp, response));
+
+    guest_free(vs->alloc, req_addr);
+    guest_free(vs->alloc, resp_addr);
+    guest_free(vs->alloc, data_in_addr);
+    guest_free(vs->alloc, data_out_addr);
+    return response;
+}
+
 /* Tests only initialization so far. TODO: Replace with functional tests */
 static void pci_nop(void)
 {
@@ -66,6 +217,26 @@ static void hotplug(void)
     qvirtio_scsi_stop();
 }
 
+/* Test WRITE SAME with the lba not aligned */
+static void test_unaligned_write_same(void)
+{
+    QVirtIOSCSI *vs;
+    uint8_t buf[512] = { 0 };
+    const uint8_t write_same_cdb[CDB_SIZE] = { 0x41, 0x00, 0x00, 0x00, 0x00,
+                                               0x01, 0x00, 0x00, 0x02, 0x00 };
+
+    qvirtio_scsi_start("-drive file=blkdebug::null-co://,if=none,id=dr1"
+                       ",format=raw,file.align=4k "
+                       "-device scsi-disk,drive=dr1,lun=0,scsi-id=1");
+    vs = qvirtio_scsi_pci_init(PCI_SLOT);
+
+    g_assert_cmphex(0, ==,
+        virtio_scsi_do_command(vs, write_same_cdb, NULL, 0, buf, 512));
+
+    qvirtio_scsi_pci_free(vs);
+    qvirtio_scsi_stop();
+}
+
 int main(int argc, char **argv)
 {
     int ret;
@@ -73,6 +244,8 @@ int main(int argc, char **argv)
     g_test_init(&argc, &argv, NULL);
     qtest_add_func("/virtio/scsi/pci/nop", pci_nop);
     qtest_add_func("/virtio/scsi/pci/hotplug", hotplug);
+    qtest_add_func("/virtio/scsi/pci/scsi-disk/unaligned-write-same",
+                   test_unaligned_write_same);
 
     ret = g_test_run();
 
-- 
1.9.3

Re: [Qemu-devel] [PATCH v2 0/5] virtio-test: Test case update

[Fam Zheng]

Ping?

Re: [Qemu-devel] [PATCH v2 0/5] virtio-test: Test case update

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Fri, Apr 24, 2015 at 07:35:15PM +0800, Fam Zheng wrote:
> v2: Fix CDB for WRITE SAME. [Paolo]
> 
> Thanks to Marc Marí's work on libqos virtio support, it's now very easy to add
> a test case to drive a virtio-scsi device.
> 
> The added test covers the recent fix for unaligned zero write in block layer,
> we exercise it here with scsi-disk WRITE SAME.
> 
> 
> Fam Zheng (5):
>   tests: Link libqos virtio object to virtio-scsi-test
>   libqos: Allow calling guest_free on NULL pointer
>   libqos: Complete virtio device ID definition list
>   tests: virtio-scsi: Move start/stop to individual test functions
>   tests: virtio-scsi: Add test for unaligned WRITE SAME
> 
>  tests/Makefile           |   2 +-
>  tests/libqos/malloc.c    |   3 +
>  tests/libqos/virtio.h    |  10 ++-
>  tests/virtio-scsi-test.c | 201 +++++++++++++++++++++++++++++++++++++++++++++--
>  4 files changed, 207 insertions(+), 9 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

I think Andreas is traveling and may be offline.  Probably best to take
this through Paolo's SCSI tree.

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] [PATCH v2 0/5] virtio-test: Test case update

[Paolo Bonzini]

On 09/06/2015 12:13, Stefan Hajnoczi wrote:
> On Fri, Apr 24, 2015 at 07:35:15PM +0800, Fam Zheng wrote:
>> v2: Fix CDB for WRITE SAME. [Paolo]
>> 
>> Thanks to Marc Marí's work on libqos virtio support, it's now
>> very easy to add a test case to drive a virtio-scsi device.
>> 
>> The added test covers the recent fix for unaligned zero write in
>> block layer, we exercise it here with scsi-disk WRITE SAME.
>> 
>> 
>> Fam Zheng (5): tests: Link libqos virtio object to
>> virtio-scsi-test libqos: Allow calling guest_free on NULL
>> pointer libqos: Complete virtio device ID definition list tests:
>> virtio-scsi: Move start/stop to individual test functions tests:
>> virtio-scsi: Add test for unaligned WRITE SAME
>> 
>> tests/Makefile           |   2 +- tests/libqos/malloc.c    |   3
>> + tests/libqos/virtio.h    |  10 ++- tests/virtio-scsi-test.c |
>> 201 +++++++++++++++++++++++++++++++++++++++++++++-- 4 files
>> changed, 207 insertions(+), 9 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> I think Andreas is traveling and may be offline.  Probably best to
> take this through Paolo's SCSI tree.

Ok, will do.

Paolo