From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym3Ws-0000Xf-8y for qemu-devel@nongnu.org; Sat, 25 Apr 2015 13:06:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ym3Wp-0002zP-3u for qemu-devel@nongnu.org; Sat, 25 Apr 2015 13:06:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52796 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym3Wo-0002z9-UF for qemu-devel@nongnu.org; Sat, 25 Apr 2015 13:06:07 -0400 Message-ID: <553BC973.2030506@suse.de> Date: Sat, 25 Apr 2015 19:05:55 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1429975686-19494-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1429975686-19494-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: agraf@suse.de, Juan Quintela Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: > The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK= . > There were even some functions using object_dynamic_cast() calls > followed by assert(), which is exactly what OBJECT_CHECK does (by > calling object_dynamic_cast_assert()). Suggest s/OBJECT_CHECK/OBJECT_CHECK()/g everywhere for clarity. >=20 > Signed-off-by: Eduardo Habkost > --- > qjson.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Andreas F=E4rber Wasn't aware QJSON is using QOM - assuming this will go through some QAPI/QMP tree. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)