From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmQ15-0006qL-PB for qemu-devel@nongnu.org; Sun, 26 Apr 2015 13:06:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmPyO-0003A0-DA for qemu-devel@nongnu.org; Sun, 26 Apr 2015 13:04:07 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:34754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmPyO-00039n-5q for qemu-devel@nongnu.org; Sun, 26 Apr 2015 13:04:04 -0400 Received: by wicmx19 with SMTP id mx19so67789117wic.1 for ; Sun, 26 Apr 2015 10:04:03 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <553D1A7F.8080803@redhat.com> Date: Sun, 26 Apr 2015 19:03:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1429829878-26862-1-git-send-email-minyard@acm.org> <1429829878-26862-3-git-send-email-minyard@acm.org> <20150426110026-mutt-send-email-mst@redhat.com> In-Reply-To: <20150426110026-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , minyard@acm.org Cc: Corey Minyard , qemu-devel@nongnu.org On 26/04/2015 11:05, Michael S. Tsirkin wrote: >> + >> +#define FW_CFG_IPMI_INTERFACE 0x30 >> +#define FW_CFG_IPMI_BASE_ADDR 0x31 >> +#define FW_CFG_IPMI_REG_SPACE 0x32 >> +#define FW_CFG_IPMI_REG_SPACING 0x33 >> +#define FW_CFG_IPMI_SLAVE_ADDR 0x34 >> +#define FW_CFG_IPMI_IRQ 0x35 >> +#define FW_CFG_IPMI_VERSION 0x36 >> + >> +#define FW_CFG_MAX_ENTRY (FW_CFG_IPMI_VERSION + 1) Also, what is this used for? I haven't seen firmware patches, maybe it's obsoleted by SMBIOS support in QEMU? Paolo