From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Auger <eric.auger@linaro.org>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Alex Williamson <alex.williamson@redhat.com>,
eric.auger@st.com,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier
Date: Mon, 27 Apr 2015 12:39:35 +0200 [thread overview]
Message-ID: <553E11E7.7070704@redhat.com> (raw)
In-Reply-To: <553DF2AA.2070102@linaro.org>
On 27/04/2015 10:26, Eric Auger wrote:
>> > One of my long term goals is to try and get rid of sysbus IRQ
>> > abstraction completely in favor of just qdev gpios. This means
>> > features that apply to GPIOs automatically apply to IRQs and vice
>> > versa. Can your notifier hook be pushed up to the qdev GPIO level to
>> > make it more globally usable and avoid a new feature to sysbus IRQs?
> Yes sure, I am going to put the notifier in DeviceClass then.
I've thought too about this, and I'm not sure about it.
It would mean you have to pass the gpio name (e.g.
SYSBUS_DEVICE_GPIO_IRQ) to the hook, and in the case of sysbus IRQs this
would leak the SYSBUS_DEVICE_GPIO_IRQ abstraction to the implementors of
the hook.
Paolo
next prev parent reply other threads:[~2015-04-27 10:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 12:39 [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier Eric Auger
2015-04-27 4:09 ` Peter Crosthwaite
2015-04-27 8:26 ` Eric Auger
2015-04-27 10:39 ` Paolo Bonzini [this message]
2015-04-27 12:20 ` Eric Auger
2015-04-27 13:37 ` Paolo Bonzini
2015-04-27 14:39 ` Peter Crosthwaite
2015-04-27 14:56 ` Eric Auger
2015-04-27 15:01 ` Paolo Bonzini
2015-04-27 17:43 ` Peter Crosthwaite
2015-04-28 6:46 ` Eric Auger
2015-04-28 6:57 ` Peter Crosthwaite
2015-04-28 7:01 ` Eric Auger
2015-04-28 9:04 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E11E7.7070704@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=eric.auger@linaro.org \
--cc=eric.auger@st.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=patches@linaro.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).