From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmgRz-0003rJ-Kk for qemu-devel@nongnu.org; Mon, 27 Apr 2015 06:39:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmgRw-0004gL-F1 for qemu-devel@nongnu.org; Mon, 27 Apr 2015 06:39:43 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:34614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmgRw-0004gD-7D for qemu-devel@nongnu.org; Mon, 27 Apr 2015 06:39:40 -0400 Received: by wicmx19 with SMTP id mx19so80802375wic.1 for ; Mon, 27 Apr 2015 03:39:39 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <553E11E7.7070704@redhat.com> Date: Mon, 27 Apr 2015 12:39:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1429879153-23476-1-git-send-email-eric.auger@linaro.org> <553DF2AA.2070102@linaro.org> In-Reply-To: <553DF2AA.2070102@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger , Peter Crosthwaite Cc: "kvmarm@lists.cs.columbia.edu" , Alex Williamson , eric.auger@st.com, "qemu-devel@nongnu.org Developers" , Patch Tracking On 27/04/2015 10:26, Eric Auger wrote: >> > One of my long term goals is to try and get rid of sysbus IRQ >> > abstraction completely in favor of just qdev gpios. This means >> > features that apply to GPIOs automatically apply to IRQs and vice >> > versa. Can your notifier hook be pushed up to the qdev GPIO level to >> > make it more globally usable and avoid a new feature to sysbus IRQs? > Yes sure, I am going to put the notifier in DeviceClass then. I've thought too about this, and I'm not sure about it. It would mean you have to pass the gpio name (e.g. SYSBUS_DEVICE_GPIO_IRQ) to the hook, and in the case of sysbus IRQs this would leak the SYSBUS_DEVICE_GPIO_IRQ abstraction to the implementors of the hook. Paolo