From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH target-arm 2/2] arm: cpu.h: Delete unused cpu_pc_from_tb()
Date: Mon, 27 Apr 2015 15:02:57 +0300 [thread overview]
Message-ID: <553E2571.2000700@msgid.tls.msk.ru> (raw)
In-Reply-To: <a07c62df4232de834d97e01a981281c68d97fbbc.1430096379.git.crosthwaite.peter@gmail.com>
27.04.2015 04:38, Peter Crosthwaite wrote:
> No code uses the cpu_pc_from_tb() function. Delete.
>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> target-arm/cpu.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index 7069103..c9c5d30 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -1874,15 +1874,6 @@ static inline void cpu_get_tb_cpu_state(CPUARMState *env, target_ulong *pc,
>
> #include "exec/exec-all.h"
>
> -static inline void cpu_pc_from_tb(CPUARMState *env, TranslationBlock *tb)
This function is also used in target-tricore/cpu.h, and is mentioned
in comments in tcg/tcg.h. Should these be removed as well?
Thanks,
/mjt
next prev parent reply other threads:[~2015-04-27 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 1:38 [Qemu-devel] [PATCH target-arm 0/2] Unused code cleanups Peter Crosthwaite
2015-04-27 1:38 ` [Qemu-devel] [PATCH target-arm 1/2] arm: cpu.h: Remove unused typdefs Peter Crosthwaite
2015-04-27 14:47 ` Michael Tokarev
2015-04-27 1:38 ` [Qemu-devel] [PATCH target-arm 2/2] arm: cpu.h: Delete unused cpu_pc_from_tb() Peter Crosthwaite
2015-04-27 12:02 ` Michael Tokarev [this message]
2015-04-27 12:06 ` Michael Tokarev
2015-04-27 12:58 ` Peter Maydell
2015-04-27 19:00 ` Peter Maydell
2015-04-27 19:06 ` Peter Crosthwaite
2015-04-27 19:10 ` Peter Maydell
2015-04-29 5:43 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E2571.2000700@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).