From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmkSo-0003zj-Ui for qemu-devel@nongnu.org; Mon, 27 Apr 2015 10:56:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmkSj-00021x-Cb for qemu-devel@nongnu.org; Mon, 27 Apr 2015 10:56:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmkSj-00021t-4N for qemu-devel@nongnu.org; Mon, 27 Apr 2015 10:56:45 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3REuiXd003553 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 27 Apr 2015 10:56:44 -0400 Message-ID: <553E4E2B.7020200@redhat.com> Date: Mon, 27 Apr 2015 08:56:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1430133591-6197-1-git-send-email-ghammer@redhat.com> <1430133591-6197-2-git-send-email-ghammer@redhat.com> In-Reply-To: <1430133591-6197-2-git-send-email-ghammer@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GK4CL8aDmX47Q9FgxCsfuE1ot6TGfgGFD" Subject: Re: [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer , qemu-devel@nongnu.org Cc: imammedo@redhat.com, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GK4CL8aDmX47Q9FgxCsfuE1ot6TGfgGFD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/27/2015 05:19 AM, Gal Hammer wrote: > Signed-off-by: Gal Hammer > --- > docs/specs/vmgenid.txt | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 docs/specs/vmgenid.txt >=20 > diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt > new file mode 100644 > index 0000000..86ce6ab > --- /dev/null > +++ b/docs/specs/vmgenid.txt > @@ -0,0 +1,35 @@ > +VIRTUAL MACHINE GENERATION ID > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > + > +Copyright (C) 2014 Red Hat, Inc. Do you want to include 2015? What you have is good. But it might also be worth documenting how one would set a new value via QMP (I assume it is a matter of finding the right QOM path to the device, then using 'qom-set' on the property). Can be done as a separate patch on top, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GK4CL8aDmX47Q9FgxCsfuE1ot6TGfgGFD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVPk4rAAoJEKeha0olJ0NqeNsIAK8Hjae/AznW/hfusvVqe/UI z/KbqY/IDWC0zhboyivaGpVEBo6JQnqthN1OzhHWtptdqyFNZkepIqh6QTYx9lwe 5E4Czs0+Z5u9wivO7r5huPXdrQqf0KbVF+1mohomDOKBCsjVeZSXWC94MFN7+FdP 7zYzxqVgrMTnUgf7+/IOuyM6ZoyM/XAWdOkaQcxs5bCtgyYsCp0kOktfq+YPYLi7 bIcMrwc71ngJqsMBp5RDwaunBe9qT9Umd1EaAGKiAbqKW47gPehDa1FFOK7kOo3o T2N7mdOuiAeM+0OiObkQYRe+yiM70pa1leHZx75Ct/jtuTYngHixcQ7vzkCcJdA= =b3hD -----END PGP SIGNATURE----- --GK4CL8aDmX47Q9FgxCsfuE1ot6TGfgGFD--