From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmkXX-0005Rd-Tj for qemu-devel@nongnu.org; Mon, 27 Apr 2015 11:01:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmkXT-0004EI-58 for qemu-devel@nongnu.org; Mon, 27 Apr 2015 11:01:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmkXS-0004EC-U1 for qemu-devel@nongnu.org; Mon, 27 Apr 2015 11:01:39 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3RF1be5010167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 27 Apr 2015 11:01:37 -0400 Message-ID: <553E4F50.4030301@redhat.com> Date: Mon, 27 Apr 2015 09:01:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1430133591-6197-1-git-send-email-ghammer@redhat.com> <1430133591-6197-6-git-send-email-ghammer@redhat.com> In-Reply-To: <1430133591-6197-6-git-send-email-ghammer@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fORGMkmTIejlVIAedWikduBHQFMS7W4wn" Subject: Re: [Qemu-devel] [PATCH V15 5/5] tests: add a unit test for the vmgenid device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer , qemu-devel@nongnu.org Cc: imammedo@redhat.com, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fORGMkmTIejlVIAedWikduBHQFMS7W4wn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/27/2015 05:19 AM, Gal Hammer wrote: > Signed-off-by: Gal Hammer Subject line: Most commits do NOT end in a trailing '.'. It's less obvious if there is a preference for starting commits with a capital after the subject, but that seems to be the current prevailing trend. So I might have done: tests: Add a unit test for vmgenid device or even: vmgenid: Add a unit test (the latter approach would mean grouping all of the series under a single topic of vmgenid, instead of your approach of a different topic per patch according to which part was being modified in support of adding vmgenid. Either approach is fine by me) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fORGMkmTIejlVIAedWikduBHQFMS7W4wn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVPk9QAAoJEKeha0olJ0NqBhMH/jzl1Qv9l1EwUwAkZ+ZOiCtV +CqRfjjQamUJcpduOimFgqfML6pBaZih3nTAGAK4A+12tQwu2n+uQWRGTvgp+Vub I2X/VGrfsY3LvrfH/MGFsf6lbyAK31SSqHwsqbTAynBmrK4rh41Xsi0bOeS6yu0Z e4cVb3Lz4qddMIFFU2GNuFaQEMrc38TQya27sgOq6ERBzj8i+9dvw7CtlCqiPatg 3oBoxl9GJYzj0QN31y1zX74mm5rL1qoGRC4lnSIyRt7ilPQw5v2nIfQvnpbeZVyG 9PBZhfpTxo7vOaOAZ6hUqA6QT95EWnOoqH8dv6DgvikvApT2e2hw+a/a58Z6l+E= =gnzN -----END PGP SIGNATURE----- --fORGMkmTIejlVIAedWikduBHQFMS7W4wn--