From: Paolo Bonzini <pbonzini@redhat.com>
To: "Emilio G. Cota" <cota@braap.org>, qemu-devel@nongnu.org
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition
Date: Mon, 27 Apr 2015 17:40:59 +0200 [thread overview]
Message-ID: <553E588B.7050603@redhat.com> (raw)
In-Reply-To: <1430085867-22514-1-git-send-email-cota@braap.org>
On 27/04/2015 00:04, Emilio G. Cota wrote:
> It's defined in osdep.h and shouldn't be redefined here.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> tests/i440fx-test.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index d0bc8de..33a7ecb 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -27,8 +27,6 @@
>
> #define BROKEN 1
>
> -#define ARRAY_SIZE(array) (sizeof(array) / sizeof((array)[0]))
> -
> typedef struct TestData
> {
> int num_cpus;
>
Looks good; I am CCing qemu-trivial@nongnu.org so that Michael will
notice this patch.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2015-04-27 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 22:04 [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition Emilio G. Cota
2015-04-27 2:18 ` Peter Crosthwaite
2015-04-27 15:39 ` Emilio G. Cota
2015-04-27 15:40 ` Paolo Bonzini [this message]
2015-04-29 6:31 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E588B.7050603@redhat.com \
--to=pbonzini@redhat.com \
--cc=cota@braap.org \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).