From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yml9h-0001EE-Cs for qemu-devel@nongnu.org; Mon, 27 Apr 2015 11:41:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yml9g-0004ba-Ft for qemu-devel@nongnu.org; Mon, 27 Apr 2015 11:41:09 -0400 Sender: Paolo Bonzini Message-ID: <553E588B.7050603@redhat.com> Date: Mon, 27 Apr 2015 17:40:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430085867-22514-1-git-send-email-cota@braap.org> In-Reply-To: <1430085867-22514-1-git-send-email-cota@braap.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , qemu-devel@nongnu.org Cc: "qemu-trivial@nongnu.org" , Laszlo Ersek On 27/04/2015 00:04, Emilio G. Cota wrote: > It's defined in osdep.h and shouldn't be redefined here. > > Signed-off-by: Emilio G. Cota > --- > tests/i440fx-test.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c > index d0bc8de..33a7ecb 100644 > --- a/tests/i440fx-test.c > +++ b/tests/i440fx-test.c > @@ -27,8 +27,6 @@ > > #define BROKEN 1 > > -#define ARRAY_SIZE(array) (sizeof(array) / sizeof((array)[0])) > - > typedef struct TestData > { > int num_cpus; > Looks good; I am CCing qemu-trivial@nongnu.org so that Michael will notice this patch. Reviewed-by: Paolo Bonzini Paolo