From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmltH-0006cE-OF for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:28:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmltG-0001eZ-IC for qemu-devel@nongnu.org; Mon, 27 Apr 2015 12:28:15 -0400 Message-ID: <553E6395.2050705@redhat.com> Date: Mon, 27 Apr 2015 10:28:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1430149991-29850-1-git-send-email-stefanha@redhat.com> <1430149991-29850-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1430149991-29850-3-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RDCKdqlEHu6E4bX3d602MPn0EkBmiGKa3" Subject: Re: [Qemu-devel] [PATCH v3 2/2] block: move I/O request processing to block/io.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RDCKdqlEHu6E4bX3d602MPn0EkBmiGKa3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/27/2015 09:53 AM, Stefan Hajnoczi wrote: > The block.c file has grown to over 6000 lines. It is time to split thi= s > file so there are fewer conflicts and the code is easier to maintain. >=20 > Extract I/O request processing code: > * Read > * Write > * Zero writes and making the image empty > * Flush > * Discard > * ioctl > * Tracked requests and queuing > * Throttling and copy-on-read > * Block status and allocated functions > * Refreshing block limits > * Reading/writing vmstate > * qemu_blockalign() and friends >=20 > The patch simply moves code from block.c into block/io.c. >=20 > No code changes are made except adding the following block_int.h > functions so they can be called across block.c and block/io.c: > bdrv_set_dirty(), bdrv_reset_dirty(). Can you split this patch into two parts (one adding the new functions, the next doing code motion) so as to make the code motion even easier to review? Of course, as this patch is botched (missing block/io.c), you'll need to send v4 before I can review anyways. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RDCKdqlEHu6E4bX3d602MPn0EkBmiGKa3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVPmOVAAoJEKeha0olJ0NqtQ4H/iImefkvfRZtulbUdfjO8RCO WMZxmtK5noAOZsqyJ7V1kxuyryK7/83aWEmbbnaCNOaLJbFjprVzMh8LTaffcZko AviAolPKzr6NMI/7ZMtIEGCoflH1uJH5WXtZu+Kb6v7TobvrDw+6sUz4Ha+jcVah Ljk1m0d2BQ8cmOe6gdo9e9PrxDk305MC8qccbinE8B1pLsXIJXK1BzOkCSkiwoHf NP6PgfsBd0SCr7ZUbPF3BenZ7L0bNr8tiAdoR4JhlG8Y8KMg59w6KxoH72SHVcr0 SuXddYIu4Z4XAghKAQ0yluUAH3oXIZ2pY1ZrNajPJ5sSdI+KhG6m55GFNi8i6jI= =GMDW -----END PGP SIGNATURE----- --RDCKdqlEHu6E4bX3d602MPn0EkBmiGKa3--