qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Christopher Covington <cov@codeaurora.org>,
	Eric Auger <eric.auger@linaro.org>,
	eric.auger@st.com, qemu-devel@nongnu.org,
	peter.maydell@linaro.org, pbonzini@redhat.com
Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu,
	patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v12 3/4] hw/arm/virt: add dynamic sysbus device support
Date: Mon, 27 Apr 2015 19:04:04 +0200	[thread overview]
Message-ID: <553E6C04.1050805@suse.de> (raw)
In-Reply-To: <553E6ABB.1070703@codeaurora.org>

On 04/27/2015 06:58 PM, Christopher Covington wrote:
> Hi Alex,
>
> On 04/27/2015 09:41 AM, Alexander Graf wrote:
>
>>> --- a/hw/arm/virt.c
>>> +++ b/hw/arm/virt.c
>>> @@ -131,6 +138,7 @@ static const MemMapEntry a15memmap[] = {
>>>        [VIRT_FW_CFG] =     { 0x09020000, 0x0000000a },
>>>        [VIRT_MMIO] =       { 0x0a000000, 0x00000200 },
>>>        /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that
>>> size */
>>> +    [VIRT_PLATFORM_BUS] =   { 0x0c000000, 0x02000000 },
>> Peter, would you have a hard time if we just get rid of VIRT_MMIO completely
>> and allow users to create the mmio-virtio bridges using -device for -M
>> virt-2.4 and above?
>>
>> At the end of the day, I'm fairly sure people will end up virtio-pci anyway
>> and it's just a big waste of address space to keep VIRT_MMIO around, no?
> I'm not sure I have an opinion one way or the other, but I would like to
> understand the "big waste" argument. Is there something that users are eager
> to reuse this address space for, like more RAM?

It will get used for platform device assignment. If we only reserve 32MB 
we will quickly run out of address space to map devices into.


Alex

  reply	other threads:[~2015-04-27 17:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 15:19 [Qemu-devel] [PATCH v12 0/4] machvirt dynamic sysbus device instantiation Eric Auger
2015-04-24 15:19 ` [Qemu-devel] [PATCH v12 1/4] hw/arm/sysbus-fdt: helpers for platform bus nodes addition Eric Auger
2015-04-24 15:19 ` [Qemu-devel] [PATCH v12 2/4] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier Eric Auger
2015-04-24 15:19 ` [Qemu-devel] [PATCH v12 3/4] hw/arm/virt: add dynamic sysbus device support Eric Auger
2015-04-27 13:41   ` Alexander Graf
2015-04-27 13:54     ` Eric Auger
2015-04-27 13:56     ` Peter Maydell
2015-04-27 14:05       ` Alexander Graf
2015-04-27 16:58     ` Christopher Covington
2015-04-27 17:04       ` Alexander Graf [this message]
2015-04-27 17:10         ` Peter Maydell
2015-04-24 15:19 ` [Qemu-devel] [PATCH v12 4/4] hw/arm/virt: change indentation in a15memmap Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553E6C04.1050805@suse.de \
    --to=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=cov@codeaurora.org \
    --cc=eric.auger@linaro.org \
    --cc=eric.auger@st.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).