From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmmTq-0005RE-VF for qemu-devel@nongnu.org; Mon, 27 Apr 2015 13:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmmTn-0002bu-Mt for qemu-devel@nongnu.org; Mon, 27 Apr 2015 13:06:02 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41492 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmmTn-0002bj-Fn for qemu-devel@nongnu.org; Mon, 27 Apr 2015 13:05:59 -0400 Message-ID: <553E6C04.1050805@suse.de> Date: Mon, 27 Apr 2015 19:04:04 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1429888773-11730-1-git-send-email-eric.auger@linaro.org> <1429888773-11730-4-git-send-email-eric.auger@linaro.org> <553E3C71.1040001@suse.de> <553E6ABB.1070703@codeaurora.org> In-Reply-To: <553E6ABB.1070703@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 3/4] hw/arm/virt: add dynamic sysbus device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christopher Covington , Eric Auger , eric.auger@st.com, qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu, patches@linaro.org On 04/27/2015 06:58 PM, Christopher Covington wrote: > Hi Alex, > > On 04/27/2015 09:41 AM, Alexander Graf wrote: > >>> --- a/hw/arm/virt.c >>> +++ b/hw/arm/virt.c >>> @@ -131,6 +138,7 @@ static const MemMapEntry a15memmap[] = { >>> [VIRT_FW_CFG] = { 0x09020000, 0x0000000a }, >>> [VIRT_MMIO] = { 0x0a000000, 0x00000200 }, >>> /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that >>> size */ >>> + [VIRT_PLATFORM_BUS] = { 0x0c000000, 0x02000000 }, >> Peter, would you have a hard time if we just get rid of VIRT_MMIO completely >> and allow users to create the mmio-virtio bridges using -device for -M >> virt-2.4 and above? >> >> At the end of the day, I'm fairly sure people will end up virtio-pci anyway >> and it's just a big waste of address space to keep VIRT_MMIO around, no? > I'm not sure I have an opinion one way or the other, but I would like to > understand the "big waste" argument. Is there something that users are eager > to reuse this address space for, like more RAM? It will get used for platform device assignment. If we only reserve 32MB we will quickly run out of address space to map devices into. Alex