From: Stefan Weil <sw@weilnetz.de>
To: Michael Tokarev <mjt@tls.msk.ru>,
Thomas Huth <thuth@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/7] Remove more unused functions
Date: Mon, 27 Apr 2015 20:09:50 +0200 [thread overview]
Message-ID: <553E7B6E.1070505@weilnetz.de> (raw)
In-Reply-To: <553E1D34.4020203@msgid.tls.msk.ru>
Am 27.04.2015 um 13:27 schrieb Michael Tokarev:
> 14.03.2015 09:19, Thomas Huth wrote:
>> Here are some more patches to remove completely unused functions
>> from QEMU. Please review carefully, some of the functions might
>> still get usefull in the future again, so if you discover one,
>> please let me know, then I'll remove it from the patch series
>> again.
> Applied to -trivial, thank you!
>
> /mjt
I'm sorry that I did not notice this series earlier.
The function serial_set_frequency() is used in my personal branch for
MIPS AR7. That's not a sufficient reason to keep it, but I think that
other (maybe most) systems have a serial clock with a typical frequency
which can be changed by software (as it is the case for AR7). So if this
function is currently unused, this simply means that the serial device
emulations are incomplete.
Regards
Stefan
next prev parent reply other threads:[~2015-04-27 18:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 6:19 [Qemu-devel] [PATCH v2 0/7] Remove more unused functions Thomas Huth
2015-03-14 6:19 ` [Qemu-devel] [PATCH v2 1/7] migration: Remove " Thomas Huth
2015-03-17 13:44 ` Juan Quintela
2015-03-14 6:19 ` [Qemu-devel] [PATCH v2 2/7] vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags() Thomas Huth
2015-03-14 7:35 ` Dmitry Fleytman
2015-03-14 6:19 ` [Qemu-devel] [PATCH v2 3/7] pci: Remove unused function ich9_d2pbr_init() Thomas Huth
2015-03-18 13:20 ` Michael S. Tsirkin
2015-03-20 7:40 ` Thomas Huth
2015-03-14 6:19 ` [Qemu-devel] [PATCH v2 4/7] monitor: Remove unused functions Thomas Huth
2015-03-14 6:19 ` [Qemu-devel] [PATCH v2 5/7] usb: " Thomas Huth
2015-03-14 6:19 ` [Qemu-devel] [PATCH v2 6/7] util: " Thomas Huth
2015-03-14 6:19 ` [Qemu-devel] [PATCH v2 7/7] Remove various " Thomas Huth
2015-04-27 11:27 ` [Qemu-devel] [PATCH v2 0/7] Remove more " Michael Tokarev
2015-04-27 18:09 ` Stefan Weil [this message]
[not found] <20150318122235.7eb71f08@oc7435384737.ibm.com>
2015-04-26 13:17 ` Thomas Huth
[not found] <20150428082846.1348066e@thh440s>
2015-04-28 6:38 ` Thomas Huth
2015-04-29 6:17 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E7B6E.1070505@weilnetz.de \
--to=sw@weilnetz.de \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).