[Qemu-devel] [PULL 0/6] X86 patches

[Qemu-devel] [PULL 0/6] X86 patches

[Eduardo Habkost]

The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9:

  Open 2.4 development tree (2015-04-25 22:05:07 +0100)

are available in the git repository at:

  git://github.com/ehabkost/qemu.git tags/x86-pull-request

for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188:

  target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300)

----------------------------------------------------------------
X86 queue, 2015-04-27

----------------------------------------------------------------

Eduardo Habkost (6):
  MAINTAINERS: Add myself to X86
  MAINTAINERS: Change status of X86 to Maintained
  qemu-config: Accept empty option values
  target-i386: Make "level" and "xlevel" properties static
  target-i386: X86CPU::xlevel2 QOM property
  target-i386: Remove AMD feature flag aliases from CPU model table

 MAINTAINERS        |  3 ++-
 target-i386/cpu.c  | 50 ++++----------------------------------------------
 util/qemu-config.c |  4 +++-
 3 files changed, 9 insertions(+), 48 deletions(-)

-- 
2.1.0

[Qemu-devel] [PULL 1/6] MAINTAINERS: Add myself to X86

[Eduardo Habkost]

Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index d7e9ba2..7db4c00 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -172,6 +172,7 @@ F: hw/unicore32/
 X86
 M: Paolo Bonzini <pbonzini@redhat.com>
 M: Richard Henderson <rth@twiddle.net>
+M: Eduardo Habkost <ehabkost@redhat.com>
 S: Odd Fixes
 F: target-i386/
 F: hw/i386/
-- 
2.1.0

[Qemu-devel] [PULL 2/6] MAINTAINERS: Change status of X86 to Maintained

[Eduardo Habkost]

"Odd Fixes" doesn't reflect the current status of target-i386. We have
people looking after it, now.

Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7db4c00..f714a98 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -173,7 +173,7 @@ X86
 M: Paolo Bonzini <pbonzini@redhat.com>
 M: Richard Henderson <rth@twiddle.net>
 M: Eduardo Habkost <ehabkost@redhat.com>
-S: Odd Fixes
+S: Maintained
 F: target-i386/
 F: hw/i386/
 
-- 
2.1.0

[Qemu-devel] [PULL 3/6] qemu-config: Accept empty option values

[Eduardo Habkost]

Currently it is impossible to set an option in a config file to an empty
string, because the parser matches only lines containing non-empty
strings between double-quotes.

As sscanf() "[" conversion specifier only matches non-empty strings, add
a special case for empty strings.

Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 util/qemu-config.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/util/qemu-config.c b/util/qemu-config.c
index 2d32ce7..a393a3d 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -413,7 +413,9 @@ int qemu_config_parse(FILE *fp, QemuOptsList **lists, const char *fname)
             opts = qemu_opts_create(list, NULL, 0, &error_abort);
             continue;
         }
-        if (sscanf(line, " %63s = \"%1023[^\"]\"", arg, value) == 2) {
+        value[0] = '\0';
+        if (sscanf(line, " %63s = \"%1023[^\"]\"", arg, value) == 2 ||
+            sscanf(line, " %63s = \"\"", arg) == 1) {
             /* arg = value */
             if (opts == NULL) {
                 error_report("no group defined");
-- 
2.1.0

[Qemu-devel] [PULL 4/6] target-i386: Make "level" and "xlevel" properties static

[Eduardo Habkost]

Static properties require only 1 line of code, much simpler than the
existing code that requires writing new getters/setters.

Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 40 ++--------------------------------------
 1 file changed, 2 insertions(+), 38 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 03b33cf..2bbf01d 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1618,38 +1618,6 @@ static void x86_cpuid_version_set_stepping(Object *obj, Visitor *v,
     env->cpuid_version |= value & 0xf;
 }
 
-static void x86_cpuid_get_level(Object *obj, Visitor *v, void *opaque,
-                                const char *name, Error **errp)
-{
-    X86CPU *cpu = X86_CPU(obj);
-
-    visit_type_uint32(v, &cpu->env.cpuid_level, name, errp);
-}
-
-static void x86_cpuid_set_level(Object *obj, Visitor *v, void *opaque,
-                                const char *name, Error **errp)
-{
-    X86CPU *cpu = X86_CPU(obj);
-
-    visit_type_uint32(v, &cpu->env.cpuid_level, name, errp);
-}
-
-static void x86_cpuid_get_xlevel(Object *obj, Visitor *v, void *opaque,
-                                 const char *name, Error **errp)
-{
-    X86CPU *cpu = X86_CPU(obj);
-
-    visit_type_uint32(v, &cpu->env.cpuid_xlevel, name, errp);
-}
-
-static void x86_cpuid_set_xlevel(Object *obj, Visitor *v, void *opaque,
-                                 const char *name, Error **errp)
-{
-    X86CPU *cpu = X86_CPU(obj);
-
-    visit_type_uint32(v, &cpu->env.cpuid_xlevel, name, errp);
-}
-
 static char *x86_cpuid_get_vendor(Object *obj, Error **errp)
 {
     X86CPU *cpu = X86_CPU(obj);
@@ -2900,12 +2868,6 @@ static void x86_cpu_initfn(Object *obj)
     object_property_add(obj, "stepping", "int",
                         x86_cpuid_version_get_stepping,
                         x86_cpuid_version_set_stepping, NULL, NULL, NULL);
-    object_property_add(obj, "level", "int",
-                        x86_cpuid_get_level,
-                        x86_cpuid_set_level, NULL, NULL, NULL);
-    object_property_add(obj, "xlevel", "int",
-                        x86_cpuid_get_xlevel,
-                        x86_cpuid_set_xlevel, NULL, NULL, NULL);
     object_property_add_str(obj, "vendor",
                             x86_cpuid_get_vendor,
                             x86_cpuid_set_vendor, NULL);
@@ -2998,6 +2960,8 @@ static Property x86_cpu_properties[] = {
     DEFINE_PROP_BOOL("check", X86CPU, check_cpuid, false),
     DEFINE_PROP_BOOL("enforce", X86CPU, enforce_cpuid, false),
     DEFINE_PROP_BOOL("kvm", X86CPU, expose_kvm, true),
+    DEFINE_PROP_UINT32("level", X86CPU, env.cpuid_level, 0),
+    DEFINE_PROP_UINT32("xlevel", X86CPU, env.cpuid_xlevel, 0),
     DEFINE_PROP_END_OF_LIST()
 };
 
-- 
2.1.0

Re: [Qemu-devel] [PULL 4/6] target-i386: Make "level" and "xlevel" properties static

[Andreas Färber]

Am 27.04.2015 um 19:58 schrieb Eduardo Habkost:
> Static properties require only 1 line of code, much simpler than the
> existing code that requires writing new getters/setters.

This is missing the fact that there is a semantic difference between my
setters and those of your static properties:

> 
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 40 ++--------------------------------------
>  1 file changed, 2 insertions(+), 38 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 03b33cf..2bbf01d 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1618,38 +1618,6 @@ static void x86_cpuid_version_set_stepping(Object *obj, Visitor *v,
>      env->cpuid_version |= value & 0xf;
>  }
>  
> -static void x86_cpuid_get_level(Object *obj, Visitor *v, void *opaque,
> -                                const char *name, Error **errp)
> -{
> -    X86CPU *cpu = X86_CPU(obj);
> -
> -    visit_type_uint32(v, &cpu->env.cpuid_level, name, errp);
> -}
> -
> -static void x86_cpuid_set_level(Object *obj, Visitor *v, void *opaque,
> -                                const char *name, Error **errp)
> -{
> -    X86CPU *cpu = X86_CPU(obj);
> -
> -    visit_type_uint32(v, &cpu->env.cpuid_level, name, errp);
> -}

The setter of your static properties will prohibit setting the value
after the CPU has been realized.

If that is intended, you should at least mention it in the commit
message and not just argue with the amount of lines.

Regards,
Andreas

> -
> -static void x86_cpuid_get_xlevel(Object *obj, Visitor *v, void *opaque,
> -                                 const char *name, Error **errp)
> -{
> -    X86CPU *cpu = X86_CPU(obj);
> -
> -    visit_type_uint32(v, &cpu->env.cpuid_xlevel, name, errp);
> -}
> -
> -static void x86_cpuid_set_xlevel(Object *obj, Visitor *v, void *opaque,
> -                                 const char *name, Error **errp)
> -{
> -    X86CPU *cpu = X86_CPU(obj);
> -
> -    visit_type_uint32(v, &cpu->env.cpuid_xlevel, name, errp);
> -}
> -
>  static char *x86_cpuid_get_vendor(Object *obj, Error **errp)
>  {
>      X86CPU *cpu = X86_CPU(obj);
> @@ -2900,12 +2868,6 @@ static void x86_cpu_initfn(Object *obj)
>      object_property_add(obj, "stepping", "int",
>                          x86_cpuid_version_get_stepping,
>                          x86_cpuid_version_set_stepping, NULL, NULL, NULL);
> -    object_property_add(obj, "level", "int",
> -                        x86_cpuid_get_level,
> -                        x86_cpuid_set_level, NULL, NULL, NULL);
> -    object_property_add(obj, "xlevel", "int",
> -                        x86_cpuid_get_xlevel,
> -                        x86_cpuid_set_xlevel, NULL, NULL, NULL);
>      object_property_add_str(obj, "vendor",
>                              x86_cpuid_get_vendor,
>                              x86_cpuid_set_vendor, NULL);
> @@ -2998,6 +2960,8 @@ static Property x86_cpu_properties[] = {
>      DEFINE_PROP_BOOL("check", X86CPU, check_cpuid, false),
>      DEFINE_PROP_BOOL("enforce", X86CPU, enforce_cpuid, false),
>      DEFINE_PROP_BOOL("kvm", X86CPU, expose_kvm, true),
> +    DEFINE_PROP_UINT32("level", X86CPU, env.cpuid_level, 0),
> +    DEFINE_PROP_UINT32("xlevel", X86CPU, env.cpuid_xlevel, 0),
>      DEFINE_PROP_END_OF_LIST()
>  };
>  
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PULL 4/6] target-i386: Make "level" and "xlevel" properties static

[Eduardo Habkost]

On Mon, Apr 27, 2015 at 08:23:06PM +0200, Andreas Färber wrote:
> Am 27.04.2015 um 19:58 schrieb Eduardo Habkost:
> > Static properties require only 1 line of code, much simpler than the
> > existing code that requires writing new getters/setters.
> 
> This is missing the fact that there is a semantic difference between my
> setters and those of your static properties:
> 
> > 
> > Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  target-i386/cpu.c | 40 ++--------------------------------------
> >  1 file changed, 2 insertions(+), 38 deletions(-)
> > 
> > diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> > index 03b33cf..2bbf01d 100644
> > --- a/target-i386/cpu.c
> > +++ b/target-i386/cpu.c
> > @@ -1618,38 +1618,6 @@ static void x86_cpuid_version_set_stepping(Object *obj, Visitor *v,
> >      env->cpuid_version |= value & 0xf;
> >  }
> >  
> > -static void x86_cpuid_get_level(Object *obj, Visitor *v, void *opaque,
> > -                                const char *name, Error **errp)
> > -{
> > -    X86CPU *cpu = X86_CPU(obj);
> > -
> > -    visit_type_uint32(v, &cpu->env.cpuid_level, name, errp);
> > -}
> > -
> > -static void x86_cpuid_set_level(Object *obj, Visitor *v, void *opaque,
> > -                                const char *name, Error **errp)
> > -{
> > -    X86CPU *cpu = X86_CPU(obj);
> > -
> > -    visit_type_uint32(v, &cpu->env.cpuid_level, name, errp);
> > -}
> 
> The setter of your static properties will prohibit setting the value
> after the CPU has been realized.
> 
> If that is intended, you should at least mention it in the commit
> message and not just argue with the amount of lines.

That's a bug in all the existing setters in target-i386/cpu.c, and I
wasn't aware of the bug until a few days ago (long after this patch was
submitted). One of my work in progress branches includes a patch that
fixes all setters to check if the CPU is already realized.

I will update the commit message to mention the bug fix and re-send the
pull request.

-- 
Eduardo

[Qemu-devel] [PULL 5/6] target-i386: X86CPU::xlevel2 QOM property

[Eduardo Habkost]

We already have "level" and "xlevel", only "xlevel2" is missing.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 2bbf01d..e657f10 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2077,7 +2077,7 @@ static void x86_cpu_load_def(X86CPU *cpu, X86CPUDefinition *def, Error **errp)
     object_property_set_int(OBJECT(cpu), def->model, "model", errp);
     object_property_set_int(OBJECT(cpu), def->stepping, "stepping", errp);
     object_property_set_int(OBJECT(cpu), def->xlevel, "xlevel", errp);
-    env->cpuid_xlevel2 = def->xlevel2;
+    object_property_set_int(OBJECT(cpu), def->xlevel2, "xlevel2", errp);
     cpu->cache_info_passthrough = def->cache_info_passthrough;
     object_property_set_str(OBJECT(cpu), def->model_id, "model-id", errp);
     for (w = 0; w < FEATURE_WORDS; w++) {
@@ -2962,6 +2962,7 @@ static Property x86_cpu_properties[] = {
     DEFINE_PROP_BOOL("kvm", X86CPU, expose_kvm, true),
     DEFINE_PROP_UINT32("level", X86CPU, env.cpuid_level, 0),
     DEFINE_PROP_UINT32("xlevel", X86CPU, env.cpuid_xlevel, 0),
+    DEFINE_PROP_UINT32("xlevel2", X86CPU, env.cpuid_xlevel2, 0),
     DEFINE_PROP_END_OF_LIST()
 };
 
-- 
2.1.0

[Qemu-devel] [PULL 6/6] target-i386: Remove AMD feature flag aliases from CPU model table

[Eduardo Habkost]

When CPU vendor is AMD, the AMD feature alias bits on
CPUID[0x80000001].EDX are already automatically copied from CPUID[1].EDX
on x86_cpu_realizefn(). When CPU vendor is Intel, those bits are
reserved and should be zero. On either case, those bits shouldn't be set
in the CPU model table.

Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index e657f10..3305e09 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -688,7 +688,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
         .features[FEAT_1_ECX] =
             CPUID_EXT_SSE3 | CPUID_EXT_CX16 | CPUID_EXT_POPCNT,
         .features[FEAT_8000_0001_EDX] =
-            (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) |
             CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX,
         .features[FEAT_8000_0001_ECX] =
             CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM |
@@ -711,7 +710,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
             CPUID_EXT_SSE3 | CPUID_EXT_MONITOR | CPUID_EXT_CX16 |
             CPUID_EXT_POPCNT,
         .features[FEAT_8000_0001_EDX] =
-            (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) |
             CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX |
             CPUID_EXT2_3DNOW | CPUID_EXT2_3DNOWEXT | CPUID_EXT2_MMXEXT |
             CPUID_EXT2_FFXSR | CPUID_EXT2_PDPE1GB | CPUID_EXT2_RDTSCP,
@@ -769,7 +767,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
             CPUID_EXT_SSE3 | CPUID_EXT_CX16,
         /* Missing: CPUID_EXT2_PDPE1GB, CPUID_EXT2_RDTSCP */
         .features[FEAT_8000_0001_EDX] =
-            (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) |
             CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX,
         /* Missing: CPUID_EXT3_LAHF_LM, CPUID_EXT3_CMP_LEG, CPUID_EXT3_EXTAPIC,
                     CPUID_EXT3_CR8LEG, CPUID_EXT3_ABM, CPUID_EXT3_SSE4A,
@@ -805,8 +802,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
             CPUID_MTRR | CPUID_CLFLUSH | CPUID_MCA | CPUID_PSE36,
         .features[FEAT_1_ECX] =
             CPUID_EXT_SSE3,
-        .features[FEAT_8000_0001_EDX] =
-            PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES,
         .features[FEAT_8000_0001_ECX] =
             0,
         .xlevel = 0x80000008,
@@ -888,7 +883,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
             PPRO_FEATURES | CPUID_PSE36 | CPUID_VME | CPUID_MTRR |
             CPUID_MCA,
         .features[FEAT_8000_0001_EDX] =
-            (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) |
             CPUID_EXT2_MMXEXT | CPUID_EXT2_3DNOW | CPUID_EXT2_3DNOWEXT,
         .xlevel = 0x80000008,
     },
@@ -912,7 +906,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
             CPUID_EXT_SSE3 | CPUID_EXT_MONITOR | CPUID_EXT_SSSE3 |
             CPUID_EXT_MOVBE,
         .features[FEAT_8000_0001_EDX] =
-            (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) |
             CPUID_EXT2_NX,
         .features[FEAT_8000_0001_ECX] =
             CPUID_EXT3_LAHF_LM,
-- 
2.1.0

Re: [Qemu-devel] [PULL 0/6] X86 patches

[Andreas Färber]

Am 27.04.2015 um 19:58 schrieb Eduardo Habkost:
> The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9:
> 
>   Open 2.4 development tree (2015-04-25 22:05:07 +0100)
> 
> are available in the git repository at:
> 
>   git://github.com/ehabkost/qemu.git tags/x86-pull-request
> 
> for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188:
> 
>   target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300)
> 
> ----------------------------------------------------------------
> X86 queue, 2015-04-27
> 
> ----------------------------------------------------------------
> 
> Eduardo Habkost (6):
>   MAINTAINERS: Add myself to X86
>   MAINTAINERS: Change status of X86 to Maintained
>   qemu-config: Accept empty option values
>   target-i386: Make "level" and "xlevel" properties static

Small objection.

Andreas

>   target-i386: X86CPU::xlevel2 QOM property
>   target-i386: Remove AMD feature flag aliases from CPU model table
> 
>  MAINTAINERS        |  3 ++-
>  target-i386/cpu.c  | 50 ++++----------------------------------------------
>  util/qemu-config.c |  4 +++-
>  3 files changed, 9 insertions(+), 48 deletions(-)
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PULL 0/6] X86 patches

[Andreas Färber]

Am 27.04.2015 um 20:17 schrieb Andreas Färber:
> Am 27.04.2015 um 19:58 schrieb Eduardo Habkost:
>> The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9:
>>
>>   Open 2.4 development tree (2015-04-25 22:05:07 +0100)
>>
>> are available in the git repository at:
>>
>>   git://github.com/ehabkost/qemu.git tags/x86-pull-request
>>
>> for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188:
>>
>>   target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300)
>>
>> ----------------------------------------------------------------
>> X86 queue, 2015-04-27
>>
>> ----------------------------------------------------------------
>>
>> Eduardo Habkost (6):
>>   MAINTAINERS: Add myself to X86
>>   MAINTAINERS: Change status of X86 to Maintained
>>   qemu-config: Accept empty option values
>>   target-i386: Make "level" and "xlevel" properties static
> 
> Small objection.

Also, I'm missing my PC unref refactoring in your pull?

> 
> Andreas
> 
>>   target-i386: X86CPU::xlevel2 QOM property
>>   target-i386: Remove AMD feature flag aliases from CPU model table
>>
>>  MAINTAINERS        |  3 ++-
>>  target-i386/cpu.c  | 50 ++++----------------------------------------------
>>  util/qemu-config.c |  4 +++-
>>  3 files changed, 9 insertions(+), 48 deletions(-)

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PULL 0/6] X86 patches

[Eduardo Habkost]

On Mon, Apr 27, 2015 at 08:25:20PM +0200, Andreas Färber wrote:
> Am 27.04.2015 um 20:17 schrieb Andreas Färber:
> > Am 27.04.2015 um 19:58 schrieb Eduardo Habkost:
> >> The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9:
> >>
> >>   Open 2.4 development tree (2015-04-25 22:05:07 +0100)
> >>
> >> are available in the git repository at:
> >>
> >>   git://github.com/ehabkost/qemu.git tags/x86-pull-request
> >>
> >> for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188:
> >>
> >>   target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300)
> >>
> >> ----------------------------------------------------------------
> >> X86 queue, 2015-04-27
> >>
> >> ----------------------------------------------------------------
> >>
> >> Eduardo Habkost (6):
> >>   MAINTAINERS: Add myself to X86
> >>   MAINTAINERS: Change status of X86 to Maintained
> >>   qemu-config: Accept empty option values
> >>   target-i386: Make "level" and "xlevel" properties static
> > 
> > Small objection.
> 
> Also, I'm missing my PC unref refactoring in your pull?

I hadn't reviewed it completely (then got distracted by other tasks and
forgot about it), sorry. I added a reminder to review it to my
todo-list, so you can get my Reviewed-by soon.

I assume Michael is OK with having it going through the x86 tree, even
if it touches only pc.c.

-- 
Eduardo

Re: [Qemu-devel] [PULL 0/6] X86 patches

[Michael S. Tsirkin]

On Mon, Apr 27, 2015 at 03:37:53PM -0300, Eduardo Habkost wrote:
> On Mon, Apr 27, 2015 at 08:25:20PM +0200, Andreas Färber wrote:
> > Am 27.04.2015 um 20:17 schrieb Andreas Färber:
> > > Am 27.04.2015 um 19:58 schrieb Eduardo Habkost:
> > >> The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9:
> > >>
> > >>   Open 2.4 development tree (2015-04-25 22:05:07 +0100)
> > >>
> > >> are available in the git repository at:
> > >>
> > >>   git://github.com/ehabkost/qemu.git tags/x86-pull-request
> > >>
> > >> for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188:
> > >>
> > >>   target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300)
> > >>
> > >> ----------------------------------------------------------------
> > >> X86 queue, 2015-04-27
> > >>
> > >> ----------------------------------------------------------------
> > >>
> > >> Eduardo Habkost (6):
> > >>   MAINTAINERS: Add myself to X86
> > >>   MAINTAINERS: Change status of X86 to Maintained
> > >>   qemu-config: Accept empty option values
> > >>   target-i386: Make "level" and "xlevel" properties static
> > > 
> > > Small objection.
> > 
> > Also, I'm missing my PC unref refactoring in your pull?
> 
> I hadn't reviewed it completely (then got distracted by other tasks and
> forgot about it), sorry. I added a reminder to review it to my
> todo-list, so you can get my Reviewed-by soon.
> 
> I assume Michael is OK with having it going through the x86 tree, even
> if it touches only pc.c.

I don't know which patches these are, sorry.
Was I Cc'd?


> -- 
> Eduardo

Re: [Qemu-devel] [PULL 0/6] X86 patches

[Eduardo Habkost]

On Mon, Apr 27, 2015 at 08:54:24PM +0200, Michael S. Tsirkin wrote:
> On Mon, Apr 27, 2015 at 03:37:53PM -0300, Eduardo Habkost wrote:
> > On Mon, Apr 27, 2015 at 08:25:20PM +0200, Andreas Färber wrote:
> > > Am 27.04.2015 um 20:17 schrieb Andreas Färber:
> > > > Am 27.04.2015 um 19:58 schrieb Eduardo Habkost:
> > > >> The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9:
> > > >>
> > > >>   Open 2.4 development tree (2015-04-25 22:05:07 +0100)
> > > >>
> > > >> are available in the git repository at:
> > > >>
> > > >>   git://github.com/ehabkost/qemu.git tags/x86-pull-request
> > > >>
> > > >> for you to fetch changes up to bdcfb55a486a5ccd04b1cf7bb1616d2a60149188:
> > > >>
> > > >>   target-i386: Remove AMD feature flag aliases from CPU model table (2015-04-27 14:23:37 -0300)
> > > >>
> > > >> ----------------------------------------------------------------
> > > >> X86 queue, 2015-04-27
> > > >>
> > > >> ----------------------------------------------------------------
> > > >>
> > > >> Eduardo Habkost (6):
> > > >>   MAINTAINERS: Add myself to X86
> > > >>   MAINTAINERS: Change status of X86 to Maintained
> > > >>   qemu-config: Accept empty option values
> > > >>   target-i386: Make "level" and "xlevel" properties static
> > > > 
> > > > Small objection.
> > > 
> > > Also, I'm missing my PC unref refactoring in your pull?
> > 
> > I hadn't reviewed it completely (then got distracted by other tasks and
> > forgot about it), sorry. I added a reminder to review it to my
> > todo-list, so you can get my Reviewed-by soon.
> > 
> > I assume Michael is OK with having it going through the x86 tree, even
> > if it touches only pc.c.
> 
> I don't know which patches these are, sorry.
> Was I Cc'd?

Yes:

  Date: Tue, 17 Mar 2015 17:46:36 +0100
  From: Andreas Färber <afaerber@suse.de>
  Subject: [Qemu-devel] [PATCH for-next] pc: Ensure non-zero CPU ref count after attaching to ICC bus
  To: qemu-devel@nongnu.org
  Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, "Michael S. Tsirkin" <mst@redhat.com>, ehabkost@redhat.com, Andreas Färber <afaerber@suse.de>

-- 
Eduardo