From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmnpB-0002a8-Ph for qemu-devel@nongnu.org; Mon, 27 Apr 2015 14:32:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ymnp7-0006Oz-PN for qemu-devel@nongnu.org; Mon, 27 Apr 2015 14:32:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ymnp7-0006Ov-Hy for qemu-devel@nongnu.org; Mon, 27 Apr 2015 14:32:05 -0400 Message-ID: <553E80A3.2040908@redhat.com> Date: Mon, 27 Apr 2015 12:32:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428206887-7921-1-git-send-email-eblake@redhat.com> <1428206887-7921-12-git-send-email-eblake@redhat.com> <87h9s11lqu.fsf@blackfin.pond.sub.org> In-Reply-To: <87h9s11lqu.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D2skLfQkMGGtUeNhUJgp8xmXQFFrMeG0W" Subject: Re: [Qemu-devel] [PATCH v6 11/36] qapi: Tighten checking of unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, berto@igalia.co, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D2skLfQkMGGtUeNhUJgp8xmXQFFrMeG0W Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/27/2015 12:15 PM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Previous commits demonstrated that the generator had several >> flaws with less-than-perfect unions: >> +++ b/tests/qapi-schema/alternate-array.json >> @@ -1,4 +1,4 @@ >> -# FIXME: we do not support array branches of anonymous unions yet >> +# we do not support array branches of anonymous unions yet >> # TODO: should we support this? >> { 'type': 'One', >> 'data': { 'name': 'str' } } >=20 > FIXME added in PATCH 08, demoted to plain comment now. Any particular > reason for the churn? Poor rebasing skills on my part. I should have nuked the 'FIXME' out of commit 8, instead of churning here. >=20 > [...] >=20 > Regardless, Yeah, the churn doesn't hurt, and unless there's a good reason for a respin, I'd rather see this series go in near the beginning of 2.4 since the change to 'struct' later in the series WILL cause merge conflicts to additions to *.json files, so sooner is better than later and fighting repetitive rebases. >=20 > Reviewed-by: Markus Armbruster >=20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --D2skLfQkMGGtUeNhUJgp8xmXQFFrMeG0W Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVPoCjAAoJEKeha0olJ0NqIRMH/1JHxTnV+jtwVoO864GRUVa1 FOLKJA08mQM/f/0ECjkKLQ8ZGZUCy7kxTkB5VYEDXSLhQiWobJGvfp5kvehyO6fq tCAgHeejdew+tBoQO7J5gIwOqOfOKefhSxlapYh9UQEDFFYZZo0nrjssDZtg9jIJ pHMuFwkfAQWhnHd0pcsHXyyWrik7PSwPXgj5U+h72EKMhmBz0YrU7o6/GQel8rWF JXazV/v1+bLWRTZzjW/1t1vbH3al8wamGy90HjSVfSGbAy8nbO4H7QGM0Uvncrxt lk0AXfNwlU0MV6zH1OxiVdzEmODQl6ion6GKt19YtzEJCF40pBq16yPMQV0FX6g= =ATCJ -----END PGP SIGNATURE----- --D2skLfQkMGGtUeNhUJgp8xmXQFFrMeG0W--