From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn0ZK-0001Vn-IL for qemu-devel@nongnu.org; Tue, 28 Apr 2015 04:08:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn0ZE-0003c4-3o for qemu-devel@nongnu.org; Tue, 28 Apr 2015 04:08:38 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:11382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn0ZD-0003bo-Im for qemu-devel@nongnu.org; Tue, 28 Apr 2015 04:08:32 -0400 Message-ID: <553F3FE5.9070806@huawei.com> Date: Tue, 28 Apr 2015 16:08:05 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1429104309-3844-1-git-send-email-zhaoshenglong@huawei.com> <1429104309-3844-14-git-send-email-zhaoshenglong@huawei.com> <20150428085412.5d215d01@nial.brq.redhat.com> In-Reply-To: <20150428085412.5d215d01@nial.brq.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, alex.bennee@linaro.org, hanjun.guo@linaro.org, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org On 2015/4/28 14:54, Igor Mammedov wrote: > btw: > whole thing might be simpler if an intermediate conversion is avoided, > just pack buffer as in spec byte by byte: > > /* format: aabbccdd-eeff-gghh-iijj-kkllmmnnoopp */ > assert(strlen(uuid) == ...); > build_append_byte(var->buf, HEX2BYTE(uuid[3]); /* dd */ > build_append_byte(var->buf, HEX2BYTE(uuid[2]); /* cc */ > ... use build_append_byte(var->buf, HEX2BYTE(uuid + (3 * 2)); /* dd */ ? -- Thanks, Shannon