From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn9KP-00004y-Lo for qemu-devel@nongnu.org; Tue, 28 Apr 2015 13:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn9KL-0006x9-J2 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 13:29:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn9KL-0006x4-BF for qemu-devel@nongnu.org; Tue, 28 Apr 2015 13:29:45 -0400 Message-ID: <553FC386.7010704@redhat.com> Date: Tue, 28 Apr 2015 11:29:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428206887-7921-1-git-send-email-eblake@redhat.com> <1428206887-7921-33-git-send-email-eblake@redhat.com> <87wq0wpfuw.fsf@blackfin.pond.sub.org> In-Reply-To: <87wq0wpfuw.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gslNVwQ1tj7cV7s7WwLEWkEL0RAPWcutD" Subject: Re: [Qemu-devel] [PATCH v6 32/36] qapi: Drop tests for inline nested structs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, berto@igalia.co, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gslNVwQ1tj7cV7s7WwLEWkEL0RAPWcutD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/28/2015 07:00 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> A future patch will be using a 'name':{dictionary} entry in the >> QAPI schema to specify a default value for an optional argument; >> but existing use of inline nested structs conflicts with that goal. >> >> +++ b/tests/test-visitor-serialization.c >> @@ -1,7 +1,7 @@ >> /* >> * Unit-tests for visitor-based serialization >> * >> - * Copyright IBM, Corp. 2012 >> + * Copyright IBM, Corp. 2012, 2015 >=20 > More accurate would be: >=20 > - * Copyright IBM, Corp. 2012,2013 > + * Copyright IBM, Corp. 2014, 2015 > + * Copyright (C) 2014, 2015 Red Hat Inc. Bummer - serves me right for trusting emacs' ability to auto-add copyright, without checking which line it added to. >=20 >> * >> * Authors: >> * Michael Roth >=20 > R-by stands all the same. I'm adding this fix to a series followup, if there is no other reason to respin. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gslNVwQ1tj7cV7s7WwLEWkEL0RAPWcutD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVP8OHAAoJEKeha0olJ0NqiBIIAIHI2ZeYSNGvNHSr+VwtM5qo odD4Ag0w9H16mSj2x3VLBap1KyqX3PLaH/il+fPlI+699pPuQd+YCudrD3tDod95 KOO2E7y1unY+RHb0t9AZTBXjeYdoNvFLw88eVvLynCFVGXdIDBODzaA4Eglp8KfV skm1YqypTFenTeuR3E3DekJ5kXPdBA21L9WieXcbv5PR4+EW/udQUBAxTISyrwZ+ XZTYK36u1tGAMEz3mKqh31r2CSfvnf9jRZX9fFhrgbN9B8oVGQBpgxPNHJ7MK0ty F2EEgqEU4kqaQsoTL+PteFT3myp+enzaKEx18c0cWixpo2bO2i1uweRmvbDm7sM= =HfLl -----END PGP SIGNATURE----- --gslNVwQ1tj7cV7s7WwLEWkEL0RAPWcutD--