From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn9fh-00085a-St for qemu-devel@nongnu.org; Tue, 28 Apr 2015 13:51:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn9fe-0005ne-Lu for qemu-devel@nongnu.org; Tue, 28 Apr 2015 13:51:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn9fe-0005nY-EF for qemu-devel@nongnu.org; Tue, 28 Apr 2015 13:51:46 -0400 Message-ID: <553FC888.6090305@redhat.com> Date: Tue, 28 Apr 2015 11:51:04 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428206887-7921-1-git-send-email-eblake@redhat.com> <87618gnyex.fsf@blackfin.pond.sub.org> In-Reply-To: <87618gnyex.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CA2HWVI86BnMl1UJUORg1tollOs3DH2Fg" Subject: Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CA2HWVI86BnMl1UJUORg1tollOs3DH2Fg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/28/2015 08:02 AM, Markus Armbruster wrote: >> v6 changes are noted in each patch; in particular, several new >> patches were added (additional tests, split some patches, conversion >> to 'struct' instead of 'type'). But most of the changes were in >> direct response to review comments or rebase fallout, so I kept >> in Reviewed-by markings where possible, to help focus review on >> the remainder. >=20 > Looks good to go to me, except for new PATCH 37, where I suggested a > small change. Shouldn't hold up this series. If any other patch still= > lacks my R-by, let me know. Easier as a followup? Respin just the one patch? Or bite the bullet and rebase the entire series (fixing the other trivial items and adding R-b along the way)? >=20 >> I wrote another patch while working on this series, but it was >> independent enough that I posted it separately (although I based >> the documentation in this patch as if that, or Markus' alternative, >> had been applied): >> https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg00373.html >=20 > Both need a trivial respin to correct a pasto. Yours has a more > elaborate commit message, and a test. Mine is less code, in part > because it uses a single qnull object instead of allocating one for eac= h > use, and it has separate patches for the qobject and the json-parser > change. >=20 > We can pick one, of we can combine the best of both into a new > mini-series. Preferences? I'll tackle a new mini-series with the best of both (I like your idea of reusing the same object across all uses, instead of creating a new one each time, particularly since it resulted in a smaller patch) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CA2HWVI86BnMl1UJUORg1tollOs3DH2Fg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVP8iIAAoJEKeha0olJ0NqqfwH/2QxYNyiSCEdclXu+Cv7nPsK LU9+0EqxO4zSLtqhZyksrHhSPYQDu1Lmu0nfYzOV7r3PU5VU4IAYRO7aJvPv/sGi edUNWmxWIp5AML1fCaRNDp6oI4kcr3btgDDTi4lQKcomZ4FXPJO/PoEDRnEcr8SW 1IlMZDEgla4FzvzOYMt3ejBpWGSvfFwdoSpdlHXwxAfz0N62MAU4XjjUtuTD8BF0 Mo45HXKROs+7INTMRiS0/wvngeIgF38jB7e8SawJSYPD0bz3klznNIpdrOzB7+Fw bXQfziygt7EeUltehwVn7BtbFj1ismX6L+f5v6YQrX2ikYzbG5nrihBdvnwilEE= =ZOsa -----END PGP SIGNATURE----- --CA2HWVI86BnMl1UJUORg1tollOs3DH2Fg--