From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnBOk-0004ni-2g for qemu-devel@nongnu.org; Tue, 28 Apr 2015 15:42:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnBOf-0007T6-LI for qemu-devel@nongnu.org; Tue, 28 Apr 2015 15:42:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnBOf-0007So-DU for qemu-devel@nongnu.org; Tue, 28 Apr 2015 15:42:21 -0400 Message-ID: <553FE29A.4060201@redhat.com> Date: Tue, 28 Apr 2015 13:42:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428206887-7921-1-git-send-email-eblake@redhat.com> <1428206887-7921-3-git-send-email-eblake@redhat.com> In-Reply-To: <1428206887-7921-3-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HpVNDHtCdiRwKsA6A70XgwL6vDoPNmPlL" Subject: Re: [Qemu-devel] [PATCH v6 02/36] qapi: Document type-safety considerations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.co, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HpVNDHtCdiRwKsA6A70XgwL6vDoPNmPlL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/04/2015 10:07 PM, Eric Blake wrote: > Go into more details about the various types of valid expressions > in a qapi schema, including tweaks to document fixes being done > later in the current patch series. Also fix some stale and missing > documentation in the QMP specification. >=20 > Signed-off-by: Eric Blake >=20 > --- Another self-review: > +generated C structs and parameter lists). Ordering doesn't matter > +between top-level expressions or the keys within an expression, but > +does matter within dictionary values for 'data' and 'returns' members > +of a single expression. QAPI schema input is written using 'single > +quotes' instead of JSON's "double quotes" (in contrast, QMP usage is > +strict JSON and only uses "double quotes", with no comments). As in > +JSON, trailing commas are not permitted in arrays or dictionaries. > +Input must be ASCII (although QMP supports full Unicode strings, the > +QAPI parser does not). At present, there is no place where a QAPI > +schema requires the use of JSON numbers or null. Here I claim that QMP is "" only... > +++ b/docs/qmp/qmp-spec.txt > + > +Also for convenience, the server will accept an extension of > +'single-quoted' strings in place of the usual "double-quoted" > +json-string, and both input forms of strings understand an additional > +escape sequence of "\'" for a single quote. The server will only use > +double quoting on output. =2E..which is at odds with reality. Will fix in either a followup or a v7 respin --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HpVNDHtCdiRwKsA6A70XgwL6vDoPNmPlL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVP+KaAAoJEKeha0olJ0NqoPsIAIiZdwaN1yGDSGPDhm2bAVuc JKLTFTqPkAge8+5Jw+TFq4oM3Rzlag9/5F7ISyWnEhXKnri2rnQSdR4DMVz/NEEa OvFuRLV0Xc9eErDMfg1Esj9Vyc6O6SFVv8j76W0beybbF82FlqF0ANwt92EMYKu5 bVdpL7iCvxAvAh2NMGIWibEhnSayREjggEzwXAwC3/w6W4Z3/LWQ2gTllVcwvQou UwQuTPEgnrfjReItDljjSd3D94oBmLRp0pUPdtH1CqCqA2+kSKJ2hc/doy0uCDPE laY3R+mHkTIJX923VuQVJVU1SCtlGAkhN5MSvfRER10Qf8PxoT/NvelsY+LGpgk= =pRcb -----END PGP SIGNATURE----- --HpVNDHtCdiRwKsA6A70XgwL6vDoPNmPlL--