From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnBqr-0006La-PU for qemu-devel@nongnu.org; Tue, 28 Apr 2015 16:11:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnBqm-0002nN-Rm for qemu-devel@nongnu.org; Tue, 28 Apr 2015 16:11:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnBqm-0002nI-Lo for qemu-devel@nongnu.org; Tue, 28 Apr 2015 16:11:24 -0400 Message-ID: <553FE96A.7090400@redhat.com> Date: Tue, 28 Apr 2015 14:11:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1430250938-18478-1-git-send-email-somlo@cmu.edu> In-Reply-To: <1430250938-18478-1-git-send-email-somlo@cmu.edu> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AwcaN86BnJjNWXcCtXhnLl69BRNkW834M" Subject: Re: [Qemu-devel] [PATCH v2] bios-tables-test: handle false-positive smbios signature matches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" , qemu-devel@nongnu.org Cc: gsomlo@gmail.com, kevin@koconnor.net, kraxel@redhat.com, brogers@suse.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AwcaN86BnJjNWXcCtXhnLl69BRNkW834M Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/28/2015 01:55 PM, Gabriel L. Somlo wrote: > It has been reported that sometimes the .rodata section of SeaBIOS, > containing the constant string against which the SMBIOS signature > ends up being compared, also falls withing the guest f-segment. In s/withing/within/ > that case, the test obviously fails, unless we continue searching > for the *real* smbios entry point. >=20 > Rather than stopping at the first match for the SMBIOS signature > ("_SM_") in the f-segment (0xF0000-0xFFFFF), continue scanning > until either a valid entry point table is found, or the f-segment > has been exhausted. >=20 > Reported-by: Bruce Rogers > Signed-off-by: Gabriel Somlo > Tested-by: Bruce Rogers > --- > tests/bios-tables-test.c | 76 ++++++++++++++++++++++++++++------------= -------- > 1 file changed, 44 insertions(+), 32 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AwcaN86BnJjNWXcCtXhnLl69BRNkW834M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVP+lqAAoJEKeha0olJ0NqGPkH/1GhCSPW047M2HCSvM7ZIKSR DbuzyKE0uSlJCVv99uAzOYJkqJGlgPuciqC0t4O61X7JYvCzTsHaExzj6yVgHvFH vVH/1BH6wSLwnzh4xemYJxf+h5UeBZfg9v2yINhgEGWLxsJaWkQvdJdVhpv9LfMq rUWE5I7eYJ9XxW2byianLlrPnytONUOt05YIt79yCXWBRJuqaBYdJo77UWgp6Owy ebsVEjTExq0Ll/bjRFzcQ6iK6lZGlJVFs6QA/05uMO+TSOzO0Gv4exWdJ9MIHDId x4b2Tok+ewd32wZwK9LpEvtBrOFuQOZtKM6w30QUZOF7f2se9Flx/d1DIRmhsDk= =x6kw -----END PGP SIGNATURE----- --AwcaN86BnJjNWXcCtXhnLl69BRNkW834M--