From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnEcU-00009M-IH for qemu-devel@nongnu.org; Tue, 28 Apr 2015 19:08:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnEcR-00063B-Ca for qemu-devel@nongnu.org; Tue, 28 Apr 2015 19:08:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnEcR-000631-4r for qemu-devel@nongnu.org; Tue, 28 Apr 2015 19:08:47 -0400 Message-ID: <554012D3.2090601@redhat.com> Date: Tue, 28 Apr 2015 17:08:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428206887-7921-1-git-send-email-eblake@redhat.com> <1428206887-7921-8-git-send-email-eblake@redhat.com> In-Reply-To: <1428206887-7921-8-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vuiiExm10vB4PqHv2WtjTF6jL5F1rojbH" Subject: Re: [Qemu-devel] [PATCH v6 07/36] qapi: Better error messages for bad enums List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, Alberto Garcia , armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vuiiExm10vB4PqHv2WtjTF6jL5F1rojbH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/04/2015 10:07 PM, Eric Blake wrote: > The previous commit demonstrated that the generator had several > flaws with less-than-perfect enums: > +++ b/tests/qapi-schema/enum-max-member.json > @@ -1,3 +1,3 @@ > -# FIXME: we should either reject user-supplied 'max', or munge the imp= licit > -# max value we generate at the end of an array > +# we reject user-supplied 'max' for clashing with implicit enum end > +# TODO: should we instead munge the the implicit value to avoid the cl= ash? double "the" needs fixing --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vuiiExm10vB4PqHv2WtjTF6jL5F1rojbH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVQBLTAAoJEKeha0olJ0NqlhgH/j4Pxrfj1PQqN6M64fUYC4Ga 44ZDWxv3x2al5mgNgP8IaTg6FKaF/ypmLXbyb++zex/CSbeVoHAA5pPS8reIWbQ6 VtzKQK7WQUmaWh7UH+jEmxg4aZKdJgzwfKUwqFysWvPGqeAKTwkRL3j09wp+ifm6 7pw25H5F2gESCwltvlLVsRa7iA2imWpkv0z0yk8JEwZZgXTxwYKRd/FKE17YoRDW Czi0uw1oVSNApEg+wUZrXR5h5+vPSAwRHm14PxjZDxbnjbSRBJ2VLmexcdymSdmp Tu4sanqiSQcWe919SMU0uMUJWetXJ6zQtdEmAdEQ4qbmVWm2QoryMP2BY/Ue8sU= =Tds5 -----END PGP SIGNATURE----- --vuiiExm10vB4PqHv2WtjTF6jL5F1rojbH--