From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnI6T-0004Z6-H3 for qemu-devel@nongnu.org; Tue, 28 Apr 2015 22:52:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnI6Q-0008Uo-5K for qemu-devel@nongnu.org; Tue, 28 Apr 2015 22:52:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnI6Q-0008Uf-0D for qemu-devel@nongnu.org; Tue, 28 Apr 2015 22:51:58 -0400 Message-ID: <5540474A.3000607@redhat.com> Date: Tue, 28 Apr 2015 20:51:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428206887-7921-1-git-send-email-eblake@redhat.com> <1428206887-7921-12-git-send-email-eblake@redhat.com> <87h9s11lqu.fsf@blackfin.pond.sub.org> <553E80A3.2040908@redhat.com> In-Reply-To: <553E80A3.2040908@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6141V1AOPIIIee2hdEt9X5BwuFXwmPAUH" Subject: Re: [Qemu-devel] [PATCH v6 11/36] qapi: Tighten checking of unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, Alberto Garcia , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6141V1AOPIIIee2hdEt9X5BwuFXwmPAUH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/27/2015 12:32 PM, Eric Blake wrote: > On 04/27/2015 12:15 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Previous commits demonstrated that the generator had several >>> flaws with less-than-perfect unions: >=20 >>> +++ b/tests/qapi-schema/alternate-array.json >>> @@ -1,4 +1,4 @@ >>> -# FIXME: we do not support array branches of anonymous unions yet >>> +# we do not support array branches of anonymous unions yet >>> # TODO: should we support this? >>> { 'type': 'One', >>> 'data': { 'name': 'str' } } >> >> FIXME added in PATCH 08, demoted to plain comment now. Any particular= >> reason for the churn? >=20 > Poor rebasing skills on my part. I should have nuked the 'FIXME' out o= f > commit 8, instead of churning here. Actually, commit 8 was demonstrating that we didn't flag arrays as invalid even though they don't work, and this commit fixes things to start rejecting them. Meanwhile, the TODO reminds us that we may once again want to accept them, but in a working configuration. At any rate, minor wording tweaks should make it more obvious. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6141V1AOPIIIee2hdEt9X5BwuFXwmPAUH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVQEdKAAoJEKeha0olJ0Nqu9gIAIILp6VOd10846uWrgRUimL+ URZux4JRuFiE4n+n7IT1Lzy+jE2WgJ9tHSW3RtmRrurDhWODq0QHOcZRdK0qJZZt HmxMjy/GCkVSFBlX8y5/3ho9IrY2dK0jL0BtGiFEyaEa9XLqn1keHNc+jR9YXPTF R5VjvnGk/H5VbxcfnrtjasJZVc887tuqbZZogSBzj/p215Jy/17JYYFOsKCNdv5+ svJpFgipUbLarBOG6VzEUYEHcCxaHYURw+gfoI/sWkOIEjay6GDb/D+WugUtlXCg 0hkFJnpTY8CP5evXqSnCFpAVz4RBkRPIqm77cs5dn47mCqR/OjI/AIF+tOwrO2c= =NmYN -----END PGP SIGNATURE----- --6141V1AOPIIIee2hdEt9X5BwuFXwmPAUH--