From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60524)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1YnNX1-0004ym-Ix
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 04:39:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1YnNWx-00044d-R4
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 04:39:47 -0400
Received: from mail-wi0-f169.google.com ([209.85.212.169]:35089)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1YnNWx-00044L-M3
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 04:39:43 -0400
Received: by widdi4 with SMTP id di4so170535840wid.0
	for <qemu-devel@nongnu.org>; Wed, 29 Apr 2015 01:39:43 -0700 (PDT)
Message-ID: <55409830.30303@linaro.org>
Date: Wed, 29 Apr 2015 10:37:04 +0200
From: Eric Auger <eric.auger@linaro.org>
MIME-Version: 1.0
References: <1430239873-31950-1-git-send-email-eric.auger@linaro.org>
	<1430239873-31950-11-git-send-email-eric.auger@linaro.org>
	<554094DF.3010607@redhat.com>
In-Reply-To: <554094DF.3010607@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v13 10/12] qdev: check callback takes the
 property child as third argument
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, eric.auger@st.com, qemu-devel@nongnu.org, alex.williamson@redhat.com, agraf@suse.de, peter.crosthwaite@xilinx.com
Cc: kvmarm@lists.cs.columbia.edu, patches@linaro.org

On 04/29/2015 10:22 AM, Paolo Bonzini wrote:
> 
> 
> On 28/04/2015 18:51, Eric Auger wrote:
>> -    prop->check(obj, name, new_target, &local_err);
>> +    object_ref(new_target);
>> +    *child = new_target;
>> +
>> +    prop->check(obj, name, child, &local_err);
>>      if (local_err) {
>>          error_propagate(errp, local_err);
>> +        *child = old_target;
>> +        object_ref(new_target);
> 
> This should be an unref.

oups yes.

Thanks! Do I keep this series or do I revert to sysbus irq connect irq
temporary patch as per Peter's last email?

Eric
> 
> Paolo
> 
>>          return;
>>      }
>>  
>> -    object_ref(new_target);
>> -    *child = new_target;
>>      object_unref(old_target);