From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60151)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shannon.zhao@linaro.org>) id 1YnOic-0001KE-Si
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 05:55:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shannon.zhao@linaro.org>) id 1YnOiZ-0004Rz-Kq
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 05:55:50 -0400
Received: from mail-pa0-f48.google.com ([209.85.220.48]:33593)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shannon.zhao@linaro.org>) id 1YnOiZ-0004Rc-Ey
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 05:55:47 -0400
Received: by pacwv17 with SMTP id wv17so23481925pac.0
	for <qemu-devel@nongnu.org>; Wed, 29 Apr 2015 02:55:45 -0700 (PDT)
Message-ID: <5540AA99.3030700@linaro.org>
Date: Wed, 29 Apr 2015 17:55:37 +0800
From: Shannon Zhao <shannon.zhao@linaro.org>
MIME-Version: 1.0
References: <1430221873-5788-1-git-send-email-shannon.zhao@linaro.org>
	<CAFEAcA_wKDaGf6URm4Ju1KevcGfnK2W_jU8NffqOTbpWOm=GVQ@mail.gmail.com>
	<20150428151249-mutt-send-email-mst@redhat.com>
	<CAFEAcA8Ch9iCfTmudGS+BmxghNxSE4CvBdy0q4bZOEsUyMC8CA@mail.gmail.com>
In-Reply-To: <CAFEAcA8Ch9iCfTmudGS+BmxghNxSE4CvBdy0q4bZOEsUyMC8CA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to
	backends
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: hangaohuai@huawei.com, QEMU Developers <qemu-devel@nongnu.org>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, Shannon Zhao <zhaoshenglong@huawei.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Christoffer Dall <christoffer.dall@linaro.org>



On 2015/4/28 21:16, Peter Maydell wrote:
> On 28 April 2015 at 14:13, Michael S. Tsirkin <mst@redhat.com> wrote:
>> > The patches look correct to me too, but I want s390
>> > cleaned up so it does not include COMMON_FEATURES
>> > in 100 places, and I prefer merging it all together.
> It seems a bit harsh to ask Shannon to do s390 cleanup when
> he doesn't have any access to s390 guests or test cases...
> Making S390 put COMMON_FEATURES in the right places seems
> to me like a separate bit of s390-specific cleanup.
> 
> (The other cleanup we could do after this patchset would
> be to just expand out the DEFINE_VIRTIO_NET/RNG/SCSI/etc_FEATURES
> macros which are all now used in exactly one place. But

right, will send another patchset to do this.

-- 
Shannon