qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Emilio G. Cota" <cota@braap.org>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: Fam Zheng <famz@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread
Date: Wed, 29 Apr 2015 13:09:45 +0200	[thread overview]
Message-ID: <5540BBF9.6080600@redhat.com> (raw)
In-Reply-To: <20150428210457.GA12653@flamenco>



On 28/04/2015 23:04, Emilio G. Cota wrote:
> 
> commit ad45e590025c1197a7aef5164e1ae174894b0969
> Author: Emilio G. Cota <cota@braap.org>
> Date:   Tue Apr 28 16:54:44 2015 -0400
> 
>     configure: require __thread support
>     
>     The codebase doesn't build without __thread support.
>     Formalise this requirement by adding a check for it in the
>     configure script.
>     
>     Signed-off-by: Emilio G. Cota <cota@braap.org>
> 
> diff --git a/configure b/configure
> index 6969f6f..3d6591f 100755
> --- a/configure
> +++ b/configure
> @@ -1549,6 +1549,17 @@ if test "$static" = "yes" ; then
>    fi
>  fi
>  
> +# Unconditional check for compiler __thread support
> +  cat > $TMPC << EOF
> +static __thread int tls_var;
> +int main(void) { return tls_var; }
> +EOF
> +
> +if ! compile_prog "-Werror" "" ; then
> +    error_exit "Your compiler does not support the __thread specifier for " \
> +	"Thread-Local Storage (TLS). Please upgrade to a version that does."
> +fi
> +
>  if test "$pie" = ""; then
>    case "$cpu-$targetos" in
>      i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)

Yes, thanks.  I'll include the patch in my next pull request.

Paolo

  reply	other threads:[~2015-04-29 11:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 17:52 [Qemu-devel] [PATCH 0/8] RCUification of the memory API, part 1 Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread Paolo Bonzini
2015-01-13 18:40   ` Peter Maydell
2015-01-13 19:48     ` Paolo Bonzini
2015-01-13 20:00       ` Peter Maydell
2015-01-13 20:27         ` Paolo Bonzini
2015-01-13 22:07           ` Peter Maydell
2015-04-28 21:04             ` Emilio G. Cota
2015-04-29 11:09               ` Paolo Bonzini [this message]
2015-01-13 17:52 ` [Qemu-devel] [PATCH 2/8] rcu: add rcu library Paolo Bonzini
2015-01-15 10:39   ` Fam Zheng
2015-01-15 11:08     ` Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 3/8] rcu: add rcutorture Paolo Bonzini
2015-01-16  2:04   ` Fam Zheng
2015-01-16 11:22     ` Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 4/8] rcu: allow nesting of rcu_read_lock/rcu_read_unlock Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 5/8] rcu: add call_rcu Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 6/8] memory: remove assertion on memory_region_destroy Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 7/8] memory: protect current_map by RCU Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 8/8] memory: avoid ref/unref in memory_region_find Paolo Bonzini
2015-01-16 13:04 ` [Qemu-devel] [PATCH 0/8] RCUification of the memory API, part 1 Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5540BBF9.6080600@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=cota@braap.org \
    --cc=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).