From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53814)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YnPsK-0002jD-Fr
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 07:09:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YnPsH-0006gK-AH
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 07:09:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38780)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YnPsH-0006gB-2x
	for qemu-devel@nongnu.org; Wed, 29 Apr 2015 07:09:53 -0400
Message-ID: <5540BBF9.6080600@redhat.com>
Date: Wed, 29 Apr 2015 13:09:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1421171537-19118-1-git-send-email-pbonzini@redhat.com>
	<1421171537-19118-2-git-send-email-pbonzini@redhat.com>
	<CAFEAcA-W9-dVCGbqwgftPE3gk8p-_Gf2Qz2fOUHr+QXpfgxfvQ@mail.gmail.com>
	<54B57691.4020007@redhat.com>
	<CAFEAcA_+ha4zxLuTxb+dUz+RmVAKeEDfgd3mE_pHY27XyHiU4A@mail.gmail.com>
	<54B57FB0.5020908@redhat.com>
	<CAFEAcA-SsN5NvHqX5LAgMdcyytnQfxsu3qo1WTUQdqGQFTr8qQ@mail.gmail.com>
	<20150428210457.GA12653@flamenco>
In-Reply-To: <20150428210457.GA12653@flamenco>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for
	__thread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Emilio G. Cota" <cota@braap.org>, Peter Maydell <peter.maydell@linaro.org>
Cc: Fam Zheng <famz@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>



On 28/04/2015 23:04, Emilio G. Cota wrote:
> 
> commit ad45e590025c1197a7aef5164e1ae174894b0969
> Author: Emilio G. Cota <cota@braap.org>
> Date:   Tue Apr 28 16:54:44 2015 -0400
> 
>     configure: require __thread support
>     
>     The codebase doesn't build without __thread support.
>     Formalise this requirement by adding a check for it in the
>     configure script.
>     
>     Signed-off-by: Emilio G. Cota <cota@braap.org>
> 
> diff --git a/configure b/configure
> index 6969f6f..3d6591f 100755
> --- a/configure
> +++ b/configure
> @@ -1549,6 +1549,17 @@ if test "$static" = "yes" ; then
>    fi
>  fi
>  
> +# Unconditional check for compiler __thread support
> +  cat > $TMPC << EOF
> +static __thread int tls_var;
> +int main(void) { return tls_var; }
> +EOF
> +
> +if ! compile_prog "-Werror" "" ; then
> +    error_exit "Your compiler does not support the __thread specifier for " \
> +	"Thread-Local Storage (TLS). Please upgrade to a version that does."
> +fi
> +
>  if test "$pie" = ""; then
>    case "$cpu-$targetos" in
>      i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)

Yes, thanks.  I'll include the patch in my next pull request.

Paolo