From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnRO3-0002wv-At for qemu-devel@nongnu.org; Wed, 29 Apr 2015 08:46:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnRNy-0000ws-Bh for qemu-devel@nongnu.org; Wed, 29 Apr 2015 08:46:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54586 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnRNy-0000wg-59 for qemu-devel@nongnu.org; Wed, 29 Apr 2015 08:46:42 -0400 Message-ID: <5540D2AE.2090802@suse.de> Date: Wed, 29 Apr 2015 14:46:38 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1429975686-19494-1-git-send-email-ehabkost@redhat.com> <553BC973.2030506@suse.de> <20150427172320.GC25766@thinpad.lan.raisama.net> <20150429083802.06f102ea@redhat.com> In-Reply-To: <20150429083802.06f102ea@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Michael Roth , agraf@suse.de, Juan Quintela , Eduardo Habkost , qemu-devel@nongnu.org Am 29.04.2015 um 14:38 schrieb Luiz Capitulino: > On Mon, 27 Apr 2015 14:23:20 -0300 > Eduardo Habkost wrote: >=20 >> On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas F=C3=A4rber wrote: >>> Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: >>>> The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CH= ECK. >>>> There were even some functions using object_dynamic_cast() calls >>>> followed by assert(), which is exactly what OBJECT_CHECK does (by >>>> calling object_dynamic_cast_assert()). >>> >>> Suggest s/OBJECT_CHECK/OBJECT_CHECK()/g everywhere for clarity. >=20 > Everywhere? You mean, in other places? No, I count 3x in commit message including subject. Andreas > In this case someone has to > post a different patch. >=20 >> I assume it can be fixed during commit by whoever is going to queue it= . >> >>> >>>> >>>> Signed-off-by: Eduardo Habkost >>>> --- >>>> qjson.c | 10 +++++----- >>>> 1 file changed, 5 insertions(+), 5 deletions(-) >>> >>> Reviewed-by: Andreas F=C3=A4rber >>> >>> Wasn't aware QJSON is using QOM - assuming this will go through some >>> QAPI/QMP tree. >> >> The only user of qjson.c right now is migration code. Should it go thr= ough >> the migration tree? >=20 > It could be, but I can take it if nobody does. >=20 >> Also, why do we have two JSON writers in QEMU? And why do they have >> exactly the same name? >=20 > Not sure I got it, which writers? >=20 --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)