From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnTPq-0003nU-Al for qemu-devel@nongnu.org; Wed, 29 Apr 2015 10:56:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnTPj-0003AP-WB for qemu-devel@nongnu.org; Wed, 29 Apr 2015 10:56:46 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:27284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnTPj-0003AK-Qp for qemu-devel@nongnu.org; Wed, 29 Apr 2015 10:56:39 -0400 Message-ID: <5540F11D.20409@imgtec.com> Date: Wed, 29 Apr 2015 15:56:29 +0100 From: Leon Alrae MIME-Version: 1.0 References: <1425593606-5909-1-git-send-email-hpoussin@reactos.org> <5512C28D.50308@imgtec.com> In-Reply-To: <5512C28D.50308@imgtec.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/8] net/dp8393x improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent@Vivier.EU, Aurelien Jarno , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Hi Herv=C3=A9, On 25/03/2015 14:13, Leon Alrae wrote: > On 05/03/2015 22:13, Herv=C3=A9 Poussineau wrote: >> Hi, >> >> This patchset improves dp8393x network card emulation to current QEMU = standards, >> mostly decouples it from MIPS rc4030 chipset emulation, and add PROM a= nd load/save >> functionalities. >> Only required cleanup has been done on the rc4030 side. >> >> Patchset has been tested on MIPS Jazz emulation and on (yet unpublishe= d) >> m68k Quadra 800 emulation. >> >> I expect those patches go through a MIPS tree, as rc4030 and dp8393x a= re currently >> only used in MIPS Jazz emulation. >> >> Herv=C3=A9 Poussineau (8): >> rc4030: create custom DMA address space >> rc4030: use AddressSpace and address_space_rw in users >> net/dp8393x: always calculate proper checksums >> net/dp8393x: do not use old_mmio accesses >> net/dp8393x: use dp8393x_ prefix for all functions >> net/dp8393x: QOM'ify >> net/dp8393x: add PROM to store MAC address >> net/dp8393x: add load/save support >> >> hw/dma/rc4030.c | 166 ++++++++++++++++------- >> hw/mips/mips_jazz.c | 17 ++- >> hw/net/dp8393x.c | 343 ++++++++++++++++++++++++---------------= --------- >> include/hw/mips/mips.h | 13 +- >> 4 files changed, 305 insertions(+), 234 deletions(-) >> >=20 > Applied to mips-next for 2.4, thanks. Since I haven't sent out these patches yet and there were some review comments from Paolo in the meantime (https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05491.html), could you make the required corrections, please? Thanks, Leon