From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnV42-0007uE-Eo for qemu-devel@nongnu.org; Wed, 29 Apr 2015 12:42:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnV3x-0001S2-LW for qemu-devel@nongnu.org; Wed, 29 Apr 2015 12:42:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnV3x-0001Rq-Fh for qemu-devel@nongnu.org; Wed, 29 Apr 2015 12:42:17 -0400 Message-ID: <554109E2.1070809@redhat.com> Date: Wed, 29 Apr 2015 18:42:10 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430321049-11859-1-git-send-email-shannon.zhao@linaro.org> In-Reply-To: <1430321049-11859-1-git-send-email-shannon.zhao@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, peter.huangpeng@huawei.com, zhaoshenglong@huawei.com, christoffer.dall@linaro.org On 29/04/2015 17:24, Shannon Zhao wrote: > The private qdev properties of virtio devices are only used by > themselves. As Peter suggested and like what virtio-blk has done, we > should move the private qdev properties into devices and don't expose > them to avoid wrongly use. > > This patchset is based on following patchset which moves host features > to backends. > http://lists.gnu.org/archive/html/qemu-devel/2015-04/msg03785.html Nice cleanup. Reviewed-by: Paolo Bonzini