From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnXVD-0008AD-BH for qemu-devel@nongnu.org; Wed, 29 Apr 2015 15:18:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnXVA-0005MO-6D for qemu-devel@nongnu.org; Wed, 29 Apr 2015 15:18:35 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:37895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnXV9-0005MK-VW for qemu-devel@nongnu.org; Wed, 29 Apr 2015 15:18:32 -0400 Received: by wiun10 with SMTP id n10so77415528wiu.1 for ; Wed, 29 Apr 2015 12:18:31 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <55412E83.30302@redhat.com> Date: Wed, 29 Apr 2015 21:18:27 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1429975686-19494-1-git-send-email-ehabkost@redhat.com> <553BC973.2030506@suse.de> <20150427172320.GC25766@thinpad.lan.raisama.net> In-Reply-To: <20150427172320.GC25766@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , =?windows-1252?Q?Andreas_F=E4?= =?windows-1252?Q?rber?= Cc: qemu-devel@nongnu.org, agraf@suse.de, Juan Quintela , Michael Roth , Luiz Capitulino On 27/04/2015 19:23, Eduardo Habkost wrote: > Also, why do we have two JSON writers in QEMU? And why do they have > exactly the same name? qobject/qjson.c could use qjson.c... but then qjson.c probably should be changed 1) to not use QOM 2) to use GString instead of QString, just like most other places that use mutable QStrings. Paolo