From: Paolo Bonzini <pbonzini@redhat.com>
To: Jason Wang <jasowang@redhat.com>, Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Vincenzo Maffione <v.maffione@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
Luigi Rizzo <rizzo@iet.unipi.it>
Subject: Re: [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send
Date: Thu, 30 Apr 2015 12:32:25 +0200 [thread overview]
Message-ID: <554204B9.2010408@redhat.com> (raw)
In-Reply-To: <1430384353.20407.3@smtp.corp.redhat.com>
On 30/04/2015 10:59, Jason Wang wrote:
>>
>>
>> + /* If !can_send, we will want to disable the read poll, but
>> we still
>> + * need the send completion callback to enable it again,
>> which is a
>> + * sign of peer becoming ready. So call the send function
>> + * regardlessly of can_send.
>> + */
>
> It was probably not safe to depend on sent_cb to re-enable the polling.
> Since the packet could be purged in some conditions (e.g
> net_vm_change_state_handler()). So tap_send_completed won't be called in
> this case.
Doesn't qemu_net_queue_purge also call the sent_cb?
Paolo
next prev parent reply other threads:[~2015-04-30 10:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 10:37 [Qemu-devel] [RFC PATCH 0/8] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2 Fam Zheng
2015-04-29 10:37 ` [Qemu-devel] [RFC PATCH 1/8] stubs: Add qemu_set_fd_handler Fam Zheng
2015-04-29 10:37 ` [Qemu-devel] [RFC PATCH 2/8] qemu-nbd: Switch to qemu_set_fd_handler Fam Zheng
2015-04-29 10:41 ` Paolo Bonzini
2015-04-29 10:37 ` [Qemu-devel] [RFC PATCH 3/8] l2tpv3: Drop l2tpv3_can_send Fam Zheng
2015-04-29 10:37 ` [Qemu-devel] [RFC PATCH 4/8] netmap: Drop netmap_can_send Fam Zheng
2015-04-29 10:37 ` [Qemu-devel] [RFC PATCH 5/8] net/socket: Drop net_socket_can_send Fam Zheng
2015-04-29 10:37 ` [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send Fam Zheng
2015-04-29 11:05 ` Paolo Bonzini
2015-04-30 8:59 ` Jason Wang
2015-04-30 10:32 ` Paolo Bonzini [this message]
2015-05-13 5:23 ` Jason Wang
2015-04-29 10:37 ` [Qemu-devel] [RFC PATCH 7/8] Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler Fam Zheng
2015-04-29 10:37 ` [Qemu-devel] [RFC PATCH 8/8] main-loop: Drop qemu_set_fd_handler2 Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554204B9.2010408@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=stefanha@redhat.com \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).