From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ynovg-0004tQ-Bz
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 09:55:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YnovZ-0005dT-Pz
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 09:55:04 -0400
Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:37818)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YnovZ-0005dP-JE
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 09:54:57 -0400
Received: by widdi4 with SMTP id di4so18908462wid.0
	for <qemu-devel@nongnu.org>; Thu, 30 Apr 2015 06:54:56 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5542342C.7080904@redhat.com>
Date: Thu, 30 Apr 2015 15:54:52 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1430400749-647-1-git-send-email-dslutz@verizon.com>
	<1430400749-647-7-git-send-email-dslutz@verizon.com>
In-Reply-To: <1430400749-647-7-git-send-email-dslutz@verizon.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 6/7] vmport:  Add VMware all ring hack
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Don Slutz <dslutz@verizon.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Anthony Liguori <aliguori@amazon.com>, =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>



On 30/04/2015 15:32, Don Slutz wrote:
> This is done by adding a new machine property vmware-port-ring3 that
> needs to be enabled to have any effect.  It only effects accel=tcg
> mode.  It is needed if you want to use VMware tools in accel=tcg
> mode.

How does it work on KVM or Xen?

> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 3305e09..5085f29 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -2592,6 +2592,7 @@ static void x86_cpu_reset(CPUState *s)
>      X86CPUClass *xcc = X86_CPU_GET_CLASS(cpu);
>      CPUX86State *env = &cpu->env;
>      int i;
> +    bool save_vmware_port_ring3 = env->hflags2 & HF2_VMPORT_HACK_MASK;
>  
>      xcc->parent_reset(s);
>  
> @@ -2607,6 +2608,9 @@ static void x86_cpu_reset(CPUState *s)
>      env->hflags |= HF_SOFTMMU_MASK;
>  #endif
>      env->hflags2 |= HF2_GIF_MASK;
> +    if (save_vmware_port_ring3) {
> +        env->hflags2 |= HF2_VMPORT_HACK_MASK;
> +    }
>  
>      cpu_x86_update_cr0(env, 0x60000010);
>      env->a20_mask = ~0x0;

The save/restore suggests that you want a new bool-typed field in
CPUX86State instead of a bit env->hflags2.

Paolo