From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ynp18-0002hH-JA for qemu-devel@nongnu.org; Thu, 30 Apr 2015 10:00:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ynp17-00088I-N4 for qemu-devel@nongnu.org; Thu, 30 Apr 2015 10:00:42 -0400 Sender: Paolo Bonzini Message-ID: <5542357E.2040408@redhat.com> Date: Thu, 30 Apr 2015 16:00:30 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430335224-6716-1-git-send-email-mdroth@linux.vnet.ibm.com> <1430335224-6716-5-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1430335224-6716-5-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 04/15] spapr_iommu: pass object ownership to parent/owner List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: aik@ozlabs.ru, nfont@linux.vnet.ibm.com, david@gibson.dropbear.id.au, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com On 29/04/2015 21:20, Michael Roth wrote: > DRC objects attach themselves to an owner as a child > property. unref afterward to allow them to be finalized > when their owner is finalized. > > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_iommu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c > index a14cdc4..79e998b 100644 > --- a/hw/ppc/spapr_iommu.c > +++ b/hw/ppc/spapr_iommu.c > @@ -182,6 +182,7 @@ sPAPRTCETable *spapr_tce_new_table(DeviceState *owner, uint32_t liobn, > > snprintf(tmp, sizeof(tmp), "tce-table-%x", liobn); > object_property_add_child(OBJECT(owner), tmp, OBJECT(tcet), NULL); > + object_unref(OBJECT(tcet)); > > object_property_set_bool(OBJECT(tcet), true, "realized", NULL); > > Reviewed-by: Paolo Bonzini