From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52571)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Ynpx9-0006Lu-Nz
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 11:00:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Ynpx4-0007JI-DP
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 11:00:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34673)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Ynpx4-0007GS-5S
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 11:00:34 -0400
Message-ID: <5542438C.60002@redhat.com>
Date: Thu, 30 Apr 2015 17:00:28 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1430404944-7322-1-git-send-email-berrange@redhat.com>
	<1430404944-7322-5-git-send-email-berrange@redhat.com>
In-Reply-To: <1430404944-7322-5-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/7] qom: add object_new_propv /
	object_new_proplist constructors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>



On 30/04/2015 16:42, Daniel P. Berrange wrote:
> +    propname = va_arg(vargs, char *);
> +    while (propname != NULL) {
> +        const char *value = va_arg(vargs, char *);
> +
> +        g_assert(value != NULL);
> +        object_property_parse(obj, value, propname, errp);
> +        if (*errp) {
> +            goto error;
> +        }
> +        propname = va_arg(vargs, char *);
> +    }
> +
> +    object_property_add_child(container_get(object_get_root(), path),
> +                              id, obj, errp);
> +    if (*errp) {
> +        goto error;
> +    }
> +
> +    if (object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
> +        user_creatable_complete(obj, errp);
> +        if (*errp) {
> +            object_property_del(container_get(object_get_root(), path),
> +                                id, &error_abort);

Easier:

    object_unparent(obj);

> +            goto error;
> +        }
> +    }
> +
> +    return obj;

And another one: do we want to unref the object here, since we've added
a stable reference via object_property_add_child?

Do you prefer me too apply patches 1-2-3-5-6-7, minus the testcases, or
do you simply want to resubmit?

Paolo