From: Don Slutz <dslutz@verizon.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Luiz Capitulino" <lcapitulino@redhat.com>,
"Anthony Liguori" <aliguori@amazon.com>,
"Andreas Färber" <afaerber@suse.de>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v4 4/7] vmport_rpc: Add QMP access to vmport_rpc object.
Date: Thu, 30 Apr 2015 11:17:55 -0400 [thread overview]
Message-ID: <554247A3.7080709@one.verizon.com> (raw)
In-Reply-To: <55423449.7050504@redhat.com>
On 04/30/15 09:55, Paolo Bonzini wrote:
>
>
> On 30/04/2015 15:32, Don Slutz wrote:
>> +#ifdef VMPORT_SHORT
>> + info->value->key = g_strdup(ckey);
>> +#else
>> + info->value->key = g_strdup_printf("guestinfo.%s", ckey);
>> +#endif
>
> What is VMPORT_SHORT for?
>
Simpler code. Looks like a left over before I found g_strdup_printf()
and it worked. Will plan to remove.
-Don Slutz
> Paolo
>
next prev parent reply other threads:[~2015-04-30 15:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 13:32 [Qemu-devel] [PATCH v4 0/7] Add limited support of VMware's hyper-call rpc Don Slutz
2015-04-30 13:32 ` [Qemu-devel] [PATCH v4 1/7] vmport.c: Fix vmport_cmd_ram_size Don Slutz
2015-04-30 13:32 ` [Qemu-devel] [PATCH v4 2/7] vmport_rpc: Add the object vmport_rpc Don Slutz
2015-04-30 13:32 ` [Qemu-devel] [PATCH v4 3/7] vmport_rpc: Add limited support of VMware's hyper-call rpc Don Slutz
2015-04-30 13:32 ` [Qemu-devel] [PATCH v4 4/7] vmport_rpc: Add QMP access to vmport_rpc object Don Slutz
2015-04-30 13:55 ` Paolo Bonzini
2015-04-30 15:17 ` Don Slutz [this message]
2015-04-30 13:32 ` [Qemu-devel] [PATCH v4 5/7] vmport_rpc: Add migration Don Slutz
2015-04-30 13:32 ` [Qemu-devel] [PATCH v4 6/7] vmport: Add VMware all ring hack Don Slutz
2015-04-30 13:54 ` Paolo Bonzini
2015-04-30 15:15 ` Don Slutz
2015-04-30 15:23 ` Paolo Bonzini
2015-04-30 18:11 ` Don Slutz
2015-04-30 15:25 ` Paolo Bonzini
2015-04-30 13:32 ` [Qemu-devel] [PATCH v4 7/7] MAINTAINERS: add VMware port Don Slutz
2015-04-30 13:55 ` [Qemu-devel] [PATCH v4 0/7] Add limited support of VMware's hyper-call rpc Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554247A3.7080709@one.verizon.com \
--to=dslutz@verizon.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).