From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56472)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1YnqE1-0005o0-CV
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 11:18:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1YnqDx-00048o-8l
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 11:18:05 -0400
Received: from omzsmtpe04.verizonbusiness.com ([199.249.25.207]:39321)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1YnqDx-00048f-4l
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 11:18:01 -0400
From: Don Slutz <dslutz@verizon.com>
Message-ID: <554247A3.7080709@one.verizon.com>
Date: Thu, 30 Apr 2015 11:17:55 -0400
MIME-Version: 1.0
References: <1430400749-647-1-git-send-email-dslutz@verizon.com>
	<1430400749-647-5-git-send-email-dslutz@verizon.com>
	<55423449.7050504@redhat.com>
In-Reply-To: <55423449.7050504@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 4/7] vmport_rpc: Add QMP access to
	vmport_rpc object.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Anthony Liguori <aliguori@amazon.com>, =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On 04/30/15 09:55, Paolo Bonzini wrote:
> 
> 
> On 30/04/2015 15:32, Don Slutz wrote:
>> +#ifdef VMPORT_SHORT
>> +    info->value->key = g_strdup(ckey);
>> +#else
>> +    info->value->key = g_strdup_printf("guestinfo.%s", ckey);
>> +#endif
> 
> What is VMPORT_SHORT for?
> 

Simpler code.  Looks like a left over before I found g_strdup_printf()
and it worked.  Will plan to remove.
   -Don Slutz

> Paolo
>